Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Thu, Jul 31, 2025 at 02:20:08AM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
> 
> On Mon, 28 Jul 2025 17:34:55 +0200 you wrote:
> > Commit bafbdd527d56 ("phylib: Add device reset GPIO support") removed
> > devm_gpiod_get_optional() in favor of the non-devres managed
> > fwnode_get_named_gpiod(). When it was kind-of reverted by commit
> > 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()"), the devm
> > functionality was not reinstated. Nor was the GPIO unclaimed on device
> > remove. This leads to the GPIO being claimed indefinitely, even when the
> > device and/or the driver gets removed.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net] net: mdio_bus: Use devm for getting reset GPIO
>     https://git.kernel.org/netdev/net/c/3b98c9352511

This needs to be reverted, it's an abuse of devm on a device that is
not being probed. Sorry, I don't have time to generate a patch.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!