Re: [PATCH 1/2] drm/xe/compat: remove unused platform macros

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Jul 31, 2025 at 03:36:15PM +0300, Jani Nikula wrote:
> After refactors, a lot of platform macros have become unused. Remove
> them before new users have a chance to pop up.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

I trust your compiler! :)

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  .../gpu/drm/xe/compat-i915-headers/i915_drv.h | 21 -------------------
>  1 file changed, 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> index 9b7572e06f34..d8cd66a96621 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> @@ -26,34 +26,13 @@ static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
>  #define IS_I915G(dev_priv)	(dev_priv && 0)
>  #define IS_I915GM(dev_priv)	(dev_priv && 0)
>  #define IS_PINEVIEW(dev_priv)	(dev_priv && 0)
> -#define IS_IVYBRIDGE(dev_priv)	(dev_priv && 0)
>  #define IS_VALLEYVIEW(dev_priv)	(dev_priv && 0)
>  #define IS_CHERRYVIEW(dev_priv)	(dev_priv && 0)
>  #define IS_HASWELL(dev_priv)	(dev_priv && 0)
>  #define IS_BROADWELL(dev_priv)	(dev_priv && 0)
> -#define IS_SKYLAKE(dev_priv)	(dev_priv && 0)
>  #define IS_BROXTON(dev_priv)	(dev_priv && 0)
> -#define IS_KABYLAKE(dev_priv)	(dev_priv && 0)
>  #define IS_GEMINILAKE(dev_priv)	(dev_priv && 0)
> -#define IS_COFFEELAKE(dev_priv)	(dev_priv && 0)
> -#define IS_COMETLAKE(dev_priv)	(dev_priv && 0)
> -#define IS_ICELAKE(dev_priv)	(dev_priv && 0)
> -#define IS_JASPERLAKE(dev_priv)	(dev_priv && 0)
> -#define IS_ELKHARTLAKE(dev_priv)	(dev_priv && 0)
> -#define IS_TIGERLAKE(dev_priv)	IS_PLATFORM(dev_priv, XE_TIGERLAKE)
> -#define IS_ROCKETLAKE(dev_priv)	IS_PLATFORM(dev_priv, XE_ROCKETLAKE)
> -#define IS_DG1(dev_priv)        IS_PLATFORM(dev_priv, XE_DG1)
> -#define IS_ALDERLAKE_S(dev_priv) IS_PLATFORM(dev_priv, XE_ALDERLAKE_S)
> -#define IS_ALDERLAKE_P(dev_priv) (IS_PLATFORM(dev_priv, XE_ALDERLAKE_P) || \
> -				  IS_PLATFORM(dev_priv, XE_ALDERLAKE_N))
>  #define IS_DG2(dev_priv)	IS_PLATFORM(dev_priv, XE_DG2)
> -#define IS_METEORLAKE(dev_priv) IS_PLATFORM(dev_priv, XE_METEORLAKE)
> -#define IS_LUNARLAKE(dev_priv) IS_PLATFORM(dev_priv, XE_LUNARLAKE)
> -#define IS_BATTLEMAGE(dev_priv)  IS_PLATFORM(dev_priv, XE_BATTLEMAGE)
> -#define IS_PANTHERLAKE(dev_priv) IS_PLATFORM(dev_priv, XE_PANTHERLAKE)
> -
> -#define IS_HASWELL_ULT(dev_priv) (dev_priv && 0)
> -#define IS_BROADWELL_ULT(dev_priv) (dev_priv && 0)
>  
>  #define IS_MOBILE(xe) (xe && 0)
>  
> -- 
> 2.39.5
>