From: Frederick Lawler <fred@cloudflare.com>
To: Corey Minyard <corey@minyard.net>
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [RFC] Patches to disable messages during BMC reset
Date: Fri, 15 Aug 2025 16:23:08 -0500 [thread overview]
Message-ID: <aJ-lPAc2bLlvHNa3@CMGLRV3> (raw)
In-Reply-To: <20250807230648.1112569-1-corey@minyard.net>
Hi Corey,
On Thu, Aug 07, 2025 at 06:02:31PM -0500, Corey Minyard wrote:
> I went ahead and did some patches for this, since it was on my mind.
>
> With these, if a reset is sent to the BMC, the driver will disable
> messages to the BMC for a time, defaulting to 30 seconds. Don't
> modify message timing, since no messages are allowed, anyway.
>
> If a firmware update command is sent to the BMC, then just reject
> sysfs commands that query the BMC. Modify message timing and
> allow direct messages through the driver interface.
>
> Hopefully this will work around the problem, and it's a good idea,
> anyway.
>
> -corey
>
Thanks for the patches, and sorry for the delay in response.
It's one of _those weeks_. Anyway, I backported the patch series
to 6.12, and the changes seem reasonable to me overall. Ran it
through our infra on a single node, and nothing seemed to break.
I did observe with testing that resetting BMC via ipmitool on the host
did kick out sysfs reads as expected.
Resetting the BMC remotely, was not handled (this seems obvious given the state
changes are handled via ipmi_msg handler). Would the BMC send an event
to the kernel letting it know its resetting so that case could be
handled?
Best,
Fred
next prev parent reply other threads:[~2025-08-15 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 23:02 [RFC] Patches to disable messages during BMC reset Corey Minyard
2025-08-07 23:02 ` [PATCH 1/4] ipmi: Differentiate between reset and firmware update in maintenance Corey Minyard
2025-08-07 23:02 ` [PATCH 2/4] ipmi: Disable sysfs access and requests in maintenance mode Corey Minyard
2025-08-08 20:37 ` Frederick Lawler
2025-08-08 22:28 ` Corey Minyard
2025-08-07 23:02 ` [PATCH 3/4] ipmi: Add a maintenance mode sysfs file Corey Minyard
2025-08-07 23:02 ` [PATCH 4/4] ipmi: Set a timer for maintenance mode Corey Minyard
2025-08-15 21:23 ` Frederick Lawler [this message]
2025-08-16 1:56 ` [RFC] Patches to disable messages during BMC reset Corey Minyard
2025-08-18 15:14 ` Frederick Lawler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ-lPAc2bLlvHNa3@CMGLRV3 \
--to=fred@cloudflare.com \
--cc=corey@minyard.net \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.