From: Sudeep Holla <sudeep.holla@arm.com>
To: "Christoph Lameter (Ampere)" <cl@gentwo.org>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
Huang Shijie <shijie@os.amperecomputing.com>,
Sudeep Holla <sudeep.holla@arm.com>,
catalin.marinas@arm.com, will@kernel.org,
patches@amperecomputing.com, Shubhang@os.amperecomputing.com,
krzysztof.kozlowski@linaro.org, bjorn.andersson@oss.qualcomm.com,
geert+renesas@glider.be, arnd@arndb.de, nm@ti.com,
ebiggers@kernel.org, nfraprado@collabora.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: enable CONFIG_SCHED_CLUSTER
Date: Thu, 14 Aug 2025 11:07:53 +0100 [thread overview]
Message-ID: <aJ21eZPPmQVR3Nij@bogus> (raw)
In-Reply-To: <d172f30d-28ad-dd46-1385-f010107bc789@gentwo.org>
On Wed, Aug 13, 2025 at 08:55:36AM -0700, Christoph Lameter (Ampere) wrote:
> On Wed, 13 Aug 2025, Sudeep Holla wrote:
>
> > > The problem is that this information is being sourced from the ACPI PPTT.
> > > The ACPI specification (AFAIK) doesn't define a cluster, so the linux
> > > cluster information is being 'invented' based on however the firmware vendor
> > > choose to group CPU nodes in the PPTT. Which means its possible for them to
> > > unknowingly create clusters, or also fail to create them when they make
> > > sense.
> >
> > +1, completely agree. As Jeremy mentioned, it is hit or miss and cluster
> > is loosely defined and IIRC Huawei pushed this based on their platform at
> > the time and it did break some benchmarks on few other platforms. So it
> > is not a good idea to make it default config IMO.
>
> Can we figure out which platforms benchmarks were affected and why?
>
I am not sure on either. One way to figure out the affected platforms is
to merge this change and expect the platform users/maintainers to report.
> It seems the notion of a "cluster" on ARM64 is derived (I guess a better
> word than "invented" hehe) from sibling information instead of PPTT. But
> using that information should work fine right?
>
I have my doubts but I may be wrong. As mentioned in the other email in this
thread, "cluster" IMO is ill-defined both in ACPI and Arm architecture which
is the root cause for all the issue around it.
--
Regards,
Sudeep
prev parent reply other threads:[~2025-08-14 13:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 2:55 [PATCH] arm64: defconfig: enable CONFIG_SCHED_CLUSTER Huang Shijie
2025-08-11 15:13 ` Jeremy Linton
2025-08-12 3:05 ` Shijie Huang
2025-08-12 16:33 ` Christoph Lameter (Ampere)
2025-08-12 17:32 ` Jeremy Linton
2025-08-13 9:28 ` Sudeep Holla
2025-08-13 15:55 ` Christoph Lameter (Ampere)
2025-08-13 22:56 ` Christoph Lameter (Ampere)
2025-08-14 10:03 ` Sudeep Holla
2025-08-14 16:30 ` Christoph Lameter (Ampere)
2025-08-15 10:48 ` Sudeep Holla
2025-08-15 16:46 ` Jeremy Linton
2025-08-18 9:33 ` Sudeep Holla
2025-08-20 23:44 ` Christoph Lameter (Ampere)
2025-08-21 12:11 ` Sudeep Holla
2026-01-20 22:59 ` Ankur Arora
2025-08-27 2:33 ` Shijie Huang
2025-08-27 10:19 ` Sudeep Holla
2025-08-14 10:07 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ21eZPPmQVR3Nij@bogus \
--to=sudeep.holla@arm.com \
--cc=Shubhang@os.amperecomputing.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=catalin.marinas@arm.com \
--cc=cl@gentwo.org \
--cc=ebiggers@kernel.org \
--cc=geert+renesas@glider.be \
--cc=jeremy.linton@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=nm@ti.com \
--cc=patches@amperecomputing.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=shijie@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.