Re: [PATCH v3 5/8] platform/chrome: Introduce cros_ec_device_alloc()

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Fri, Aug 01, 2025 at 09:50:01AM +0100, Greg KH wrote:
> On Fri, Aug 01, 2025 at 08:41:32AM +0000, Tzung-Bi Shih wrote:
> > On Fri, Aug 01, 2025 at 10:22:18AM +0200, Greg KH wrote:
> > > On Fri, Aug 01, 2025 at 07:25:55AM +0000, Tzung-Bi Shih wrote:
> > > > On Fri, Jul 25, 2025 at 06:58:23AM +0200, Greg KH wrote:
<snip>
> > > 
> > > Nice!  At a quick glance, this does look like what we need (and if it
> > > helps, matches what was just done in the Rust kernel apis, right?)
> > 
> > Thanks for the review.  I'd need to check.  I wasn't aware of what was just
> > done in the Rust kernel APIs.
> 
> Take a look at that, if there's any way it can align up with what the
> rust code does, if possible, that would be good as we all are going to
> be crossing between the two different languages a lot :)

I'd still need some time to find and look at the relevant Rust code (language
and overall status of Rust kernel API-wise).  I guess they should spread in
rust/kernel/device.rs and rust/kernel/devres.rs?

> 
> > > Want to turn this into something real and submit it for review after you
> > > test it out with your driver to see if it does work?
> > 
> > Have tested on the draft version and it works.  Will consolidate the patches
> > and send them for further reviews.
> 
> Great!  No rush, we can't do anything until after -rc1 is out.

While I'm still finding and looking at the Rust part, sent a version [1] for
review first.

[1] https://lore.kernel.org/chrome-platform/20250814091020.1302888-1-tzungbi@kernel.org/