From: Ido Schimmel <idosch@idosch.org>
To: heminhong <heminhong@kylinos.cn>
Cc: dsahern@kernel.org, edumazet@google.com, kuba@kernel.org,
kuniyu@google.com, netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net v3] ipv6: sr: validate HMAC algorithm ID in seg6_hmac_info_add
Date: Thu, 14 Aug 2025 18:48:33 +0300 [thread overview]
Message-ID: <aJ4FUauS-3Ymarop@shredder> (raw)
In-Reply-To: <20250814063302.112132-1-heminhong@kylinos.cn>
On Thu, Aug 14, 2025 at 02:33:02PM +0800, heminhong wrote:
> From: Minhong He <heminhong@kylinos.cn>
>
> The seg6_genl_sethmac() directly uses the algorithm ID provided by the
> userspace without verifying whether it is an HMAC algorithm supported
> by the system.
> If an unsupported HMAC algorithm ID is configured, packets using SRv6 HMAC
> will be dropped during encapsulation or decapsulation.
> To keep the HMAC algorithm logic in seg6_hmac.c and perform the check
> in seg6_hmac_info_add().
The "To" doesn't seem necessary in the last sentence?
>
> Fixes: 4f4853dc1c9c ("ipv6: sr: implement API to control SR HMAC structure")
> Signed-off-by: Minhong He <heminhong@kylinos.cn>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-08-14 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 6:19 [PATCH] ipv6: sr: add validity check for algorithm ID heminhong
2025-08-12 13:52 ` Ido Schimmel
2025-08-13 6:57 ` [PATCH net-next v2] ipv6: sr: validate HMAC algorithm ID in seg6_genl_sethmac heminhong
2025-08-13 7:17 ` Kuniyuki Iwashima
2025-08-13 11:54 ` Ido Schimmel
2025-08-14 6:33 ` [PATCH net v3] ipv6: sr: validate HMAC algorithm ID in seg6_hmac_info_add heminhong
2025-08-14 15:48 ` Ido Schimmel [this message]
2025-08-15 6:38 ` [PATCH net v4] " Minhong He
2025-08-16 6:54 ` Kuniyuki Iwashima
2025-08-19 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ4FUauS-3Ymarop@shredder \
--to=idosch@idosch.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=heminhong@kylinos.cn \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.