Re: [PATCH nft 00/12] replace compound_expr_*() by type safe function

[Phil Sutter <phil@nwl.cc>]

Hi,

On Wed, Aug 13, 2025 at 04:11:32PM +0200, Pablo Neira Ayuso wrote:
> Hi,
> 
> This is a series to replace (and remove) the existing compound_expr_*()
> helper functions which is common to set, list and concat expressions
> by expression type safe variants that validate the expression type.
> 
> No rush to apply this, there is a reported regression on the JSON
> output, in case there is a need to make a new release to address it.

Patch 1 looks like a candidate for advance integration.

> Pablo Neira Ayuso (12):
>   segtree: incorrect type when aggregating concatenated set ranges
>   src: add expr_type_catchall() helper and use it
>   src: replace compound_expr_add() by type safe function
>   src: replace compound_expr_add() by type safe function
>   src: replace compound_expr_add() by type safe function

I suggest changing the subject to something more unique, e.g.:

- src: Introduce set_expr_add()
- src: Introduce concat_expr_add()
- src: Introduce list_expr_add()

Although duplicate commit subjects sometimes happen, there are
situations where it helps tremendously if one can tell them apart by
their subject, e.g. when backporting.

Cheers, Phil