From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B21F1CA0ED1 for ; Fri, 15 Aug 2025 17:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hpZzCwF6uL93t2Y3MnPgEdfK/2i/6QPs3463irDQmog=; b=Zxf5JErvzc2Jg/rAkfjMh7WE6T Et+FcQhVccgQUKsAdAo+lRn4TzDbLbaGxy0+OSvHWshsS4VHjos2x3qj+/ebJ+Du6xST0yl1Qe5By kQvHWfb+Jx4KfKI/+bfjLzbSP1r4iPLZx6S4yF4CM5ENhbcLDT9XxrE4IVWrR0JxtQo6YmCeAfGEZ eUAihkuYFm8UGNs94ZzcxNHG/zJIt9HgmjNv+/L5omwB9P0w/Jvc4FD3bZl0/Xmgbk/tUloTB9Mw3 5UMoFLrrB6jYr2v4xAYwZtFtrWO7BIVY/ySxHYuIS4Xrrw0TofXmjtQjsBtz3fkiBayNYLt+0I9TR e4Vaclhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1umxyG-000000035ZA-1krl; Fri, 15 Aug 2025 17:12:04 +0000 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1umwZ0-00000002rmt-2fI2 for kvm-riscv@lists.infradead.org; Fri, 15 Aug 2025 15:41:55 +0000 Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-323266dcf3bso1951943a91.0 for ; Fri, 15 Aug 2025 08:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755272514; x=1755877314; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mZHHNj6EVbfkylJhuGEQxcUJR48ZbvWbqL/aI2BJPfo=; b=yBsOT/6rETcPmA7eCF8m0xi/ZoXvuBU+VaBDpsVyD8qUDVPDWq+UWRq/L9P+KdM4bH cTj7A9dRoroDrz+qYqwuZMSpGFBxKtQDefC3q9whmJce+0b6j0DpydIxktcYCYTbXcHE BoM1Yqwy3gDd5ttu8cQ2Rked2ZRf4Kt3wnF1n03Dh7SgI0gUlzp/1rksKlQdICpK8Cvo tMp8SauLYca4yhCzgddivqKGQ5ESqw1v3/vDxTG0KYtb+yqmoOL9179PmFcO6MyuehY4 +yzkirhCX1yPIapV67SCLpb/gqGxbu/BB5uks+dikI7VNsPXNDY37PJVF1234wShT5Z3 Utsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755272514; x=1755877314; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZHHNj6EVbfkylJhuGEQxcUJR48ZbvWbqL/aI2BJPfo=; b=X8SfNddt6z4qkn5mZMFbL6IzRAhqtiUsnKb9Fj5JnwuPdq8CvO6rZV9GekBYLig0oO gJm++FtXihzahvWEbyZFqiEHOVhOG2gFofIvI1C94qfhu2f1hL/xsdE02r8jgZ8wfnP9 ZQdmhjtMRvFdU7Jw6fYtYOH66NsYdaTKi7e08NRWpLKGwPk0Nl/qEQaFQNTTfkGCQ6YS zHZJHzt123vVw6BDpIRWQu8V6qUpFH6Df4Pv96Y1XsItV8KRN6SLdf/juiJ/4Cd0hWDR 9WY/8RqwGMAdoVt0sRzjL3f1WKEJqUwxeDEZdhIphNwBkGQU0vGqBF0bkUDaM+OEoxoP 37mQ== X-Forwarded-Encrypted: i=1; AJvYcCWCL8I2UyrLn/UZqKbBu56/2WryjQvE5iPfdMsoelrLarnragQfRo+7qqI61PsHVewHltP0pc+o+zY=@lists.infradead.org X-Gm-Message-State: AOJu0Yxs2/fkA9lazwVnNmtTdt0ggPi0oGiX439WgxdlsHYlfrVvCzkY eAqmHxQ88/3EBpBlVoXdcekjWy2Le8aMXr+MmC3SWfly/aIh7yYcFeS9gVZ/cHTiYnIz/PxOVlW Ds2z0TQ== X-Google-Smtp-Source: AGHT+IF1xhNBmkTpZib3NykIL4xlxFbGkhXK+/yjF5LGvtuWFmTYgkxBDJw0+uZkCmQyO/RrRqfOrKLRso0= X-Received: from pjbsd7.prod.google.com ([2002:a17:90b:5147:b0:31e:a094:a39]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5104:b0:31e:4492:af48 with SMTP id 98e67ed59e1d1-32342238d44mr3660367a91.28.1755272513579; Fri, 15 Aug 2025 08:41:53 -0700 (PDT) Date: Fri, 15 Aug 2025 08:41:52 -0700 In-Reply-To: <20250815113951.GC4067720@noisy.programming.kicks-ass.net> Mime-Version: 1.0 References: <20250806195706.1650976-1-seanjc@google.com> <20250806195706.1650976-10-seanjc@google.com> <20250815113951.GC4067720@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v5 09/44] perf/x86: Switch LVTPC to/from mediated PMI vector on guest load/put context From: Sean Christopherson To: Peter Zijlstra Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Xin Li , "H. Peter Anvin" , Andy Lutomirski , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Kan Liang , Yongwei Ma , Mingwei Zhang , Xiong Zhang , Sandipan Das , Dapeng Mi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250815_084154_679873_BF403899 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Fri, Aug 15, 2025, Peter Zijlstra wrote: > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index e1df3c3bfc0d..ad22b182762e 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -6408,6 +6408,8 @@ void perf_load_guest_context(unsigned long data) > > task_ctx_sched_out(cpuctx->task_ctx, NULL, EVENT_GUEST); > > } > > > > + arch_perf_load_guest_context(data); > > So I still don't understand why this ever needs to reach the generic > code. x86 pmu driver and x86 kvm can surely sort this out inside of x86, > no? It's definitely possible to handle this entirely within x86, I just don't love switching the LVTPC without the protection of perf_ctx_lock and perf_ctx_disable(). It's not a sticking point for me if you strongly prefer something like this: diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c index 0e5048ae86fa..86b81c217b97 100644 --- a/arch/x86/kvm/pmu.c +++ b/arch/x86/kvm/pmu.c @@ -1319,7 +1319,9 @@ void kvm_mediated_pmu_load(struct kvm_vcpu *vcpu) lockdep_assert_irqs_disabled(); - perf_load_guest_context(kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVTPC)); + perf_load_guest_context(); + + perf_load_guest_lvtpc(kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVTPC)); /* * Disable all counters before loading event selectors and PMCs so that @@ -1380,5 +1382,7 @@ void kvm_mediated_pmu_put(struct kvm_vcpu *vcpu) kvm_pmu_put_guest_pmcs(vcpu); + perf_put_guest_lvtpc(); + perf_put_guest_context(); } -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C182307AC4 for ; Fri, 15 Aug 2025 15:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755272515; cv=none; b=dB9oAyz54Zd3C2WP/SxiKWrmbv2ldEPGMdFXsIyEn48b6myiMLzzMdDUKQOxg64IHQESQzBjU4yVRvG9MvRBTm0/L/rrAgH3eRKVJftwIn8helpfX6k0+aLgIeoZy9ppYdLcQKJIsvqcIohmLxBrFlh02C4OVeiaS0VTdfuHuvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755272515; c=relaxed/simple; bh=V0iQe0wXHiwXgNwjclXLeqc33EIkx7ymZ0WlHmqsCas=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=kjt1cTUISsFeP5Veq60QBgqmxotnCggOwBQqB6d2EVYkDZLdZ4eXq4j9FZTFZVZsrClKvy04B6SsywJMKEDu6QuXiP/sysI8x4ZCxfFnhy4rkwXqNQDH5c+nd/yj4ZUuSjx9bUuxwVmM8DyzvWAkXpfyk7XHnNmSwMLKLOipvxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WOTKy4Fz; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WOTKy4Fz" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-32326e09c5fso2119289a91.2 for ; Fri, 15 Aug 2025 08:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755272514; x=1755877314; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mZHHNj6EVbfkylJhuGEQxcUJR48ZbvWbqL/aI2BJPfo=; b=WOTKy4Fzr8j76uGrXmViWQk7NVhJ3MKW/n7YCHbkduDT5nTapFfpZsBpari+WiLAVH obkT2Wxd1GDp55Sx8Cqvu/CBoAOgXtIxmZdkG1XBti5sIg46nLyqVehcIDCZH9zTT29E ODLtS+t8cBm+IfYS/oXch0j0dlngfnRAZor8cQgDdchy3ho4IgErKsH/ksvBDW6/y85B KJDG/BCuh5mSmD5uOhQXo6qVkpm2txXqiLZ28d9u2U5F1RpWAUwjj/5v4qiNwHMUOAWx iS+48TBZaKRcIZpaPnyvrNEx36TMsVT25sVGU0/q2DBQnMPdayJSkZ/F0ku8R9d42V/w X6QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755272514; x=1755877314; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZHHNj6EVbfkylJhuGEQxcUJR48ZbvWbqL/aI2BJPfo=; b=RDYZjdLZUpsPTqTcqFbrlf6RseFfGno6C9En4uB+MEvotCIUx7VoACozObGFmUzFM7 4IDLEDR0W8JjomIhC1xW+atIb9GL/5QUw0r8GI/OmqAH+yEca4znKojcKieAWikWkfJ0 nEGxFDKyML8QYJOl+ZWB51u+2qXS0d6K5kDvk6Uit0TAPK7/LT8fdAmsjST6BODYvb6p ltv+edfnWQf4H80XkeVD+S/pHv22tEaJv3VvWPNcLGzXuiZUc2swPHy/dFNjb74kougi lVaZ0PjQKKMEit1kzMVYRmFUaeMW9ffLH9TYDilHamNHYAOTb5F43iIYNpR4ktH96wQF 8uGQ== X-Forwarded-Encrypted: i=1; AJvYcCXNGlRoaDc17+gCaU+ApCOj7rAwOHrDSKlEGJmNCQOop+kGBtYIhruAx+XMdafHucx4RHA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxod4NFbEk1lfL42jan1qIoFefVJMxJEqlQnp3fWPIZgcgK/xUM yduNriP6V8FDGO0XuOk3zgz6CQ2R2mU7oFtcr5GfQn9WUJ9OnHIcham+pzxst8epMDVM6JZftNR lsA1ZyQ== X-Google-Smtp-Source: AGHT+IF1xhNBmkTpZib3NykIL4xlxFbGkhXK+/yjF5LGvtuWFmTYgkxBDJw0+uZkCmQyO/RrRqfOrKLRso0= X-Received: from pjbsd7.prod.google.com ([2002:a17:90b:5147:b0:31e:a094:a39]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5104:b0:31e:4492:af48 with SMTP id 98e67ed59e1d1-32342238d44mr3660367a91.28.1755272513579; Fri, 15 Aug 2025 08:41:53 -0700 (PDT) Date: Fri, 15 Aug 2025 08:41:52 -0700 In-Reply-To: <20250815113951.GC4067720@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250806195706.1650976-1-seanjc@google.com> <20250806195706.1650976-10-seanjc@google.com> <20250815113951.GC4067720@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v5 09/44] perf/x86: Switch LVTPC to/from mediated PMI vector on guest load/put context From: Sean Christopherson To: Peter Zijlstra Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Xin Li , "H. Peter Anvin" , Andy Lutomirski , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Kan Liang , Yongwei Ma , Mingwei Zhang , Xiong Zhang , Sandipan Das , Dapeng Mi Content-Type: text/plain; charset="us-ascii" On Fri, Aug 15, 2025, Peter Zijlstra wrote: > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index e1df3c3bfc0d..ad22b182762e 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -6408,6 +6408,8 @@ void perf_load_guest_context(unsigned long data) > > task_ctx_sched_out(cpuctx->task_ctx, NULL, EVENT_GUEST); > > } > > > > + arch_perf_load_guest_context(data); > > So I still don't understand why this ever needs to reach the generic > code. x86 pmu driver and x86 kvm can surely sort this out inside of x86, > no? It's definitely possible to handle this entirely within x86, I just don't love switching the LVTPC without the protection of perf_ctx_lock and perf_ctx_disable(). It's not a sticking point for me if you strongly prefer something like this: diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c index 0e5048ae86fa..86b81c217b97 100644 --- a/arch/x86/kvm/pmu.c +++ b/arch/x86/kvm/pmu.c @@ -1319,7 +1319,9 @@ void kvm_mediated_pmu_load(struct kvm_vcpu *vcpu) lockdep_assert_irqs_disabled(); - perf_load_guest_context(kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVTPC)); + perf_load_guest_context(); + + perf_load_guest_lvtpc(kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVTPC)); /* * Disable all counters before loading event selectors and PMCs so that @@ -1380,5 +1382,7 @@ void kvm_mediated_pmu_put(struct kvm_vcpu *vcpu) kvm_pmu_put_guest_pmcs(vcpu); + perf_put_guest_lvtpc(); + perf_put_guest_context(); } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4931DCA0EE4 for ; Fri, 15 Aug 2025 17:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+LoCGs5P9Hsll4m4vTTm/Thq6DM4wy3Aj5H/m5RjEhk=; b=LOBdVzJ4lFhS5SGm56zwBm7NZ/ 1COeTH7zjjJ21EKRnEeV6ka7o4/gLrDyVyUItRC8u9VZ7DtmAiOtZa1AdvT634fzmmsZp8BSXg0Hk yDsqpiqtjTgAIVn9KAAiTgWiYWOYNoM+s+g0mGViH6JhCpI7yYmgxJmGcg3euDIFnux2SP+ckF847 jdC1mvAyDx+wTFuXV1Gu2Fq/9lDTnuMWB9OR/ZIFqjejW2vUgnypoI4PXNduGwC+NtdSDrSAbpAvp Fo6b0gONsplk/CvT+jv8dup3+/HlFeefVqxvHz1XSFv0G6Ovd3YDJx1r24EMbDK3B28zHalLoRQ44 m2Mh53Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1umxyF-000000035Yx-3cnk; Fri, 15 Aug 2025 17:12:03 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1umwZ0-00000002rms-2fky for linux-riscv@lists.infradead.org; Fri, 15 Aug 2025 15:41:55 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-32326e6b1deso2016246a91.3 for ; Fri, 15 Aug 2025 08:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755272514; x=1755877314; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mZHHNj6EVbfkylJhuGEQxcUJR48ZbvWbqL/aI2BJPfo=; b=yBsOT/6rETcPmA7eCF8m0xi/ZoXvuBU+VaBDpsVyD8qUDVPDWq+UWRq/L9P+KdM4bH cTj7A9dRoroDrz+qYqwuZMSpGFBxKtQDefC3q9whmJce+0b6j0DpydIxktcYCYTbXcHE BoM1Yqwy3gDd5ttu8cQ2Rked2ZRf4Kt3wnF1n03Dh7SgI0gUlzp/1rksKlQdICpK8Cvo tMp8SauLYca4yhCzgddivqKGQ5ESqw1v3/vDxTG0KYtb+yqmoOL9179PmFcO6MyuehY4 +yzkirhCX1yPIapV67SCLpb/gqGxbu/BB5uks+dikI7VNsPXNDY37PJVF1234wShT5Z3 Utsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755272514; x=1755877314; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZHHNj6EVbfkylJhuGEQxcUJR48ZbvWbqL/aI2BJPfo=; b=aYl93gBQPBUIDjec3rxiFM/UtsSLTwGPc9wZZ/PZcvI1MzVRXTFQ7ybiA5TCqnUti5 FiX/juJjHw5Te7sIA7mzXfL/AEDyhZ1LEISzUoIRiNScH4HCGgyuNGLN2DC+Z0fx1XZA PgJ6mX3SOyeXvLqPR4H9uBJ6mDibH0jgtK08VbpUS8RyYgPYxS1VZz1aKLinu3L2SYav AZ0hQskCh0todXl4zZF8AYA4EW2gJFNMxVDBS6NC6S1v10MhNKbqvJm8LpQwXyDTQ0Zq XmnFRi6gbjYmi6n83sSIkbWfH5uJHifg7RA178ZQ4JvatWTlpWNLDINfZFieMF6C9die O5OQ== X-Forwarded-Encrypted: i=1; AJvYcCVT1rFxxVljubU9jDRePDDkMjZHw8e7C2oX9G5Nq+Ip6xrt2v2hJ3SGBR8XCeFNEmkQJ6TqYJY0rPXhWQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yx2IqogJacowznQBShIXcsndCU6LtNXSxMfz6ByG5YWjUxcqbFg hUhFBh9EYMKrVEdli8Hw6NdEj32jGzsz3MfETyxn2QzRmyZbaIpd6VqEOIfA6JjblJXWH8PbKkq bWz/q3w== X-Google-Smtp-Source: AGHT+IF1xhNBmkTpZib3NykIL4xlxFbGkhXK+/yjF5LGvtuWFmTYgkxBDJw0+uZkCmQyO/RrRqfOrKLRso0= X-Received: from pjbsd7.prod.google.com ([2002:a17:90b:5147:b0:31e:a094:a39]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5104:b0:31e:4492:af48 with SMTP id 98e67ed59e1d1-32342238d44mr3660367a91.28.1755272513579; Fri, 15 Aug 2025 08:41:53 -0700 (PDT) Date: Fri, 15 Aug 2025 08:41:52 -0700 In-Reply-To: <20250815113951.GC4067720@noisy.programming.kicks-ass.net> Mime-Version: 1.0 References: <20250806195706.1650976-1-seanjc@google.com> <20250806195706.1650976-10-seanjc@google.com> <20250815113951.GC4067720@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v5 09/44] perf/x86: Switch LVTPC to/from mediated PMI vector on guest load/put context From: Sean Christopherson To: Peter Zijlstra Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Xin Li , "H. Peter Anvin" , Andy Lutomirski , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Kan Liang , Yongwei Ma , Mingwei Zhang , Xiong Zhang , Sandipan Das , Dapeng Mi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250815_084154_679551_6B6B2DE6 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Aug 15, 2025, Peter Zijlstra wrote: > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index e1df3c3bfc0d..ad22b182762e 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -6408,6 +6408,8 @@ void perf_load_guest_context(unsigned long data) > > task_ctx_sched_out(cpuctx->task_ctx, NULL, EVENT_GUEST); > > } > > > > + arch_perf_load_guest_context(data); > > So I still don't understand why this ever needs to reach the generic > code. x86 pmu driver and x86 kvm can surely sort this out inside of x86, > no? It's definitely possible to handle this entirely within x86, I just don't love switching the LVTPC without the protection of perf_ctx_lock and perf_ctx_disable(). It's not a sticking point for me if you strongly prefer something like this: diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c index 0e5048ae86fa..86b81c217b97 100644 --- a/arch/x86/kvm/pmu.c +++ b/arch/x86/kvm/pmu.c @@ -1319,7 +1319,9 @@ void kvm_mediated_pmu_load(struct kvm_vcpu *vcpu) lockdep_assert_irqs_disabled(); - perf_load_guest_context(kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVTPC)); + perf_load_guest_context(); + + perf_load_guest_lvtpc(kvm_lapic_get_reg(vcpu->arch.apic, APIC_LVTPC)); /* * Disable all counters before loading event selectors and PMCs so that @@ -1380,5 +1382,7 @@ void kvm_mediated_pmu_put(struct kvm_vcpu *vcpu) kvm_pmu_put_guest_pmcs(vcpu); + perf_put_guest_lvtpc(); + perf_put_guest_context(); } _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv