From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D057CA0ED1 for ; Fri, 15 Aug 2025 16:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DE6ZwSAtZwzPcuot4Yb+O4EBQ/wF92C5TRn6BbnajEU=; b=jQhPY4gm7OoqRcoSBwO3xbEl1d 373kYICeBK8gSnse+YWHPQodm4G63Zqff7Bhg25IgFJdPFlkiLeNvlXYoNs/Opyi4HRQNcMm0Z1FJ u2weQTXWQcZ+/VzzQRdpKQgaQNmmXGPXbCmFKcROAqhZPMLYBfAmkFnAomGdRP5RNRfE=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1umxAa-0000uS-9p; Fri, 15 Aug 2025 16:20:45 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1umxAY-0000uA-Cv for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Aug 2025 16:20:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nYMony5sC8GAVbMQBrOINfD/pMK1q6qsHPU0yHRs9Jw=; b=GLqVMvc45wdmIQA7tjqpBHvs+f CN2u5Nnb09WGuYa5ItHfLhwg3MNCZzZqB0L3vmHh3oMOJGe0zlVfwcteToPj/JkSluGUeDkCbK1no 4TEam/mmIVZTchjKhnhk8XazoNoXKpFsbuiT4s/nRWQBSOBoSoXJGUA55xrUOwTO+VPg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To: From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nYMony5sC8GAVbMQBrOINfD/pMK1q6qsHPU0yHRs9Jw=; b=gP/P5MIew/KF+4LZmjD6nRx1ht AtCDWRwIsqi7man1pH3fovPvpnFK363eqzSuijv4bPGCIVuN4er4RzFPv02YAbrK3QXSBI6uhxoon iIFvxZ4TfedG1KPjfNj/Svz+kwA08AVa3VGzJcOkMeiSv/yNhU2BOs7mv1Mu8wqp3Q5I=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1umxAY-0008PN-KN for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Aug 2025 16:20:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0CF4AA58309 for ; Fri, 15 Aug 2025 16:20:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 934CAC4CEEB; Fri, 15 Aug 2025 16:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755274831; bh=LiYEkGe4+vvYPDOoShkAaz5e8Puzmaj0zK3r3FwaX08=; h=Date:From:To:Subject:References:In-Reply-To:From; b=JOEkffsNYbw9wt45dnlbQnrTH4QXworbfNo7bhVRiOkP8BzbMfFBqRw81ApCIbWE9 HvUfJU53KhVz0nIhe1PRmf5NbBTXuA2F1EHz3A+VEHYr99NPYjvoVWdhvLja2SE2rm GiR3xoY5y0bO8T0ICkz9fEVaD7o++QzRj/iIB9OY5daxn+nJvHfzetur3P8nUuDb2f tROUIhKpYgiXyJRKSRPCebrKJ4oKvjDvZXVB3uJzE1/AG0oK+Kyc3T6zCWPbMyuKGg yeM9OB7MZ+LkJqWi5CqsV2OaZTcboVMAoGMxNcqD7B8GOnykg56uQopapPi4tXQ6dK Yz5Z3dV3TlVuQ== Date: Fri, 15 Aug 2025 16:20:29 +0000 To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Message-ID: References: <20250812235814.960924-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1umxAY-0008PN-KN Subject: Re: [f2fs-dev] [PATCH v3] f2fs: show the list of donation files X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This patch introduces a proc entry to show the currently enrolled donation files. - "File path" indicates a file. - "Status" a. "Donated" means the file is registed in the donation list by fadvise(offset, length, POSIX_FADV_NOREUSE) b. "Evicted" means the donated pages were reclaimed. - "Offset (kb)" and "Length (kb) show the registered donation range. - "Cached pages (kb)" shows the amount of cached pages in the inode page cache. For example, Donation List # of files : 2 File path Status Offset (kb) Length (kb) Cached pages (kb) --- /local/tmp/test2 Donated 0 1048576 2097152 /local/tmp/test Evicted 0 1048576 1048576 Signed-off-by: Jaegeuk Kim --- v3 - use loff_t fs/f2fs/sysfs.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 1ffaf9e74ce9..5d0f7364dbb8 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -1769,6 +1769,68 @@ static int __maybe_unused disk_map_seq_show(struct seq_file *seq, return 0; } +static int __maybe_unused donation_list_seq_show(struct seq_file *seq, + void *offset) +{ + struct super_block *sb = seq->private; + struct f2fs_sb_info *sbi = F2FS_SB(sb); + struct inode *inode; + struct f2fs_inode_info *fi; + struct dentry *dentry; + char *buf, *path; + int i; + + buf = f2fs_getname(sbi); + if (!buf) + return 0; + + seq_printf(seq, "Donation List\n"); + seq_printf(seq, " # of files : %u\n", sbi->donate_files); + seq_printf(seq, " %-50s %10s %15s %15s %20s\n", + "File path", "Status", "Offset (kb)", + "Length (kb)", "Cached pages (kb)"); + seq_printf(seq, "---\n"); + + for (i = 0; i < sbi->donate_files; i++) { + spin_lock(&sbi->inode_lock[DONATE_INODE]); + if (list_empty(&sbi->inode_list[DONATE_INODE])) { + spin_unlock(&sbi->inode_lock[DONATE_INODE]); + break; + } + fi = list_first_entry(&sbi->inode_list[DONATE_INODE], + struct f2fs_inode_info, gdonate_list); + list_move_tail(&fi->gdonate_list, &sbi->inode_list[DONATE_INODE]); + inode = igrab(&fi->vfs_inode); + spin_unlock(&sbi->inode_lock[DONATE_INODE]); + + if (!inode) + continue; + + inode_lock_shared(inode); + + dentry = d_find_alias(inode); + if (!dentry) { + path = NULL; + } else { + path = dentry_path_raw(dentry, buf, PATH_MAX); + if (IS_ERR(path)) + goto next; + } + seq_printf(seq, " %-50s %10s %15llu %15llu %20llu\n", + path ? path : "", + is_inode_flag_set(inode, FI_DONATE_FINISHED) ? + "Evicted" : "Donated", + (loff_t)fi->donate_start << (PAGE_SHIFT - 10), + (loff_t)(fi->donate_end + 1) << (PAGE_SHIFT - 10), + (loff_t)inode->i_mapping->nrpages << (PAGE_SHIFT - 10)); +next: + inode_unlock_shared(inode); + iput(inode); + } + f2fs_putname(buf); + return 0; +} + #ifdef CONFIG_F2FS_FAULT_INJECTION static int __maybe_unused inject_stats_seq_show(struct seq_file *seq, void *offset) @@ -1878,6 +1940,8 @@ int f2fs_register_sysfs(struct f2fs_sb_info *sbi) discard_plist_seq_show, sb); proc_create_single_data("disk_map", 0444, sbi->s_proc, disk_map_seq_show, sb); + proc_create_single_data("donation_list", 0444, sbi->s_proc, + donation_list_seq_show, sb); #ifdef CONFIG_F2FS_FAULT_INJECTION proc_create_single_data("inject_stats", 0444, sbi->s_proc, inject_stats_seq_show, sb); -- 2.51.0.rc1.163.g2494970778-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC3E1EE7DC for ; Fri, 15 Aug 2025 16:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755274832; cv=none; b=Ywo90lfzuN2wDQmWoXobM6VmQ6AJQaLY1BjrJvEcw6G178ij0Lp8huSIh9TZmueMq1b1asnTzXB/j95W2BjLA75I4jbLJL+wJlevoEPKlG8gy0TVgCVmIlqzgQ1+vobZ8UonuP31nCowR72z5C6BUijqpDRe380A5m37gDDxr8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755274832; c=relaxed/simple; bh=LiYEkGe4+vvYPDOoShkAaz5e8Puzmaj0zK3r3FwaX08=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nqh7Z+c1LgigAEjwLbU1nE1Xa9nGNBgAVC0eZhD9GmBuWxP2uGI6kc9vjsaFnh7juOc8yuhodKIwwXCDG16tCG0IGZAI9NprndchDluWehvZO8f7lQz8+xp0qjLEeGTXsQdNZMat7p65SwLYkpan1xdowIPH7dpLpE0gbJ2O4dw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JOEkffsN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JOEkffsN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 934CAC4CEEB; Fri, 15 Aug 2025 16:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755274831; bh=LiYEkGe4+vvYPDOoShkAaz5e8Puzmaj0zK3r3FwaX08=; h=Date:From:To:Subject:References:In-Reply-To:From; b=JOEkffsNYbw9wt45dnlbQnrTH4QXworbfNo7bhVRiOkP8BzbMfFBqRw81ApCIbWE9 HvUfJU53KhVz0nIhe1PRmf5NbBTXuA2F1EHz3A+VEHYr99NPYjvoVWdhvLja2SE2rm GiR3xoY5y0bO8T0ICkz9fEVaD7o++QzRj/iIB9OY5daxn+nJvHfzetur3P8nUuDb2f tROUIhKpYgiXyJRKSRPCebrKJ4oKvjDvZXVB3uJzE1/AG0oK+Kyc3T6zCWPbMyuKGg yeM9OB7MZ+LkJqWi5CqsV2OaZTcboVMAoGMxNcqD7B8GOnykg56uQopapPi4tXQ6dK Yz5Z3dV3TlVuQ== Date: Fri, 15 Aug 2025 16:20:29 +0000 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v3] f2fs: show the list of donation files Message-ID: References: <20250812235814.960924-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: This patch introduces a proc entry to show the currently enrolled donation files. - "File path" indicates a file. - "Status" a. "Donated" means the file is registed in the donation list by fadvise(offset, length, POSIX_FADV_NOREUSE) b. "Evicted" means the donated pages were reclaimed. - "Offset (kb)" and "Length (kb) show the registered donation range. - "Cached pages (kb)" shows the amount of cached pages in the inode page cache. For example, Donation List # of files : 2 File path Status Offset (kb) Length (kb) Cached pages (kb) --- /local/tmp/test2 Donated 0 1048576 2097152 /local/tmp/test Evicted 0 1048576 1048576 Signed-off-by: Jaegeuk Kim --- v3 - use loff_t fs/f2fs/sysfs.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 1ffaf9e74ce9..5d0f7364dbb8 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -1769,6 +1769,68 @@ static int __maybe_unused disk_map_seq_show(struct seq_file *seq, return 0; } +static int __maybe_unused donation_list_seq_show(struct seq_file *seq, + void *offset) +{ + struct super_block *sb = seq->private; + struct f2fs_sb_info *sbi = F2FS_SB(sb); + struct inode *inode; + struct f2fs_inode_info *fi; + struct dentry *dentry; + char *buf, *path; + int i; + + buf = f2fs_getname(sbi); + if (!buf) + return 0; + + seq_printf(seq, "Donation List\n"); + seq_printf(seq, " # of files : %u\n", sbi->donate_files); + seq_printf(seq, " %-50s %10s %15s %15s %20s\n", + "File path", "Status", "Offset (kb)", + "Length (kb)", "Cached pages (kb)"); + seq_printf(seq, "---\n"); + + for (i = 0; i < sbi->donate_files; i++) { + spin_lock(&sbi->inode_lock[DONATE_INODE]); + if (list_empty(&sbi->inode_list[DONATE_INODE])) { + spin_unlock(&sbi->inode_lock[DONATE_INODE]); + break; + } + fi = list_first_entry(&sbi->inode_list[DONATE_INODE], + struct f2fs_inode_info, gdonate_list); + list_move_tail(&fi->gdonate_list, &sbi->inode_list[DONATE_INODE]); + inode = igrab(&fi->vfs_inode); + spin_unlock(&sbi->inode_lock[DONATE_INODE]); + + if (!inode) + continue; + + inode_lock_shared(inode); + + dentry = d_find_alias(inode); + if (!dentry) { + path = NULL; + } else { + path = dentry_path_raw(dentry, buf, PATH_MAX); + if (IS_ERR(path)) + goto next; + } + seq_printf(seq, " %-50s %10s %15llu %15llu %20llu\n", + path ? path : "", + is_inode_flag_set(inode, FI_DONATE_FINISHED) ? + "Evicted" : "Donated", + (loff_t)fi->donate_start << (PAGE_SHIFT - 10), + (loff_t)(fi->donate_end + 1) << (PAGE_SHIFT - 10), + (loff_t)inode->i_mapping->nrpages << (PAGE_SHIFT - 10)); +next: + inode_unlock_shared(inode); + iput(inode); + } + f2fs_putname(buf); + return 0; +} + #ifdef CONFIG_F2FS_FAULT_INJECTION static int __maybe_unused inject_stats_seq_show(struct seq_file *seq, void *offset) @@ -1878,6 +1940,8 @@ int f2fs_register_sysfs(struct f2fs_sb_info *sbi) discard_plist_seq_show, sb); proc_create_single_data("disk_map", 0444, sbi->s_proc, disk_map_seq_show, sb); + proc_create_single_data("donation_list", 0444, sbi->s_proc, + donation_list_seq_show, sb); #ifdef CONFIG_F2FS_FAULT_INJECTION proc_create_single_data("inject_stats", 0444, sbi->s_proc, inject_stats_seq_show, sb); -- 2.51.0.rc1.163.g2494970778-goog