All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Viktor Kurilko <murlockkinght@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3] Add a feature for mapping a host unix socket to a guest tcp socket
Date: Mon, 4 Aug 2025 16:53:02 +0200	[thread overview]
Message-ID: <aJDJTqgYxOpbGZs2@begin> (raw)
In-Reply-To: <20250804141125.313313-1-murlockkinght@gmail.com>

Hello,

Viktor Kurilko, le lun. 04 août 2025 21:05:01 +0700, a ecrit:
> > Does that not behave oddly when given a path?
> 
> I didn't quite understand what you meant. If you mean that we try to parse the
> host address despite the fact that it doesn't make sense for a unix socket,

Yes.

> then I added a check that in the case of using a unix socket, the host
> address should be empty. As an alternative solution, I can suggest
> specifying the unix socket
> path in the host address place and omitting the port initialization in this case.

-serial uses:
              tcp:[host]:port[,server=on|off][,wait=on|off][,node‐
              lay=on|off][,reconnect-ms=milliseconds]
                     The TCP Net Console has two modes  of  operation.  It  can

              unix:path[,server=on|off][,wait=on|off][,reconnect-ms=millisec‐
              onds]
                     A unix domain socket is used instead of a tcp socket.  The

So I'd say we'd want to follow the same principle, i.e.

-hostfwd=unix:hostpath-[guestaddr]:guestport

BTW, your patch needs to update the various documentations of hostfwd,
so users now that it's now possible to use unix sockets.


Samuel


      reply	other threads:[~2025-08-04 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 14:05 [PATCH v3] Add a feature for mapping a host unix socket to a guest tcp socket Viktor Kurilko
2025-08-04 14:53 ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJDJTqgYxOpbGZs2@begin \
    --to=samuel.thibault@gnu.org \
    --cc=murlockkinght@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.