From: Daniel Kiper via Grub-devel <grub-devel@gnu.org>
To: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
Alec Brown <alec.r.brown@oracle.com>,
The development of GRUB 2 <grub-devel@gnu.org>,
christopher.obbard@linaro.org,
Jan Setje-Eilers <jan.setjeeilers@oracle.com>,
Mate Kukri <mate.kukri@canonical.com>,
Peter Jones <pjones@redhat.com>,
Leo Sandoval <lsandova@redhat.com>,
Marta Lewandowska <mlewando@redhat.com>,
Ross Philipson <ross.philipson@oracle.com>,
93sam@debian.org
Subject: Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()
Date: Mon, 4 Aug 2025 18:40:34 +0200 [thread overview]
Message-ID: <aJDigmQQFibiMmop@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAEaD8JPZJ7+Dz0YWU-sqAPmTubTpRTYVyyi_7ti-BZsoAYvn2g@mail.gmail.com>
On Fri, Aug 01, 2025 at 04:51:54PM +0300, Vladimir 'phcoder' Serbinenko wrote:
> Please don't put it into kernel unless it's used by the kernel. lib/ would be a
> better fit
Whole family of grub_str*() functions live in grub-core/kern/misc.c. So,
I am not sure why we should make an exception here. Additionally, we do
not care about the GRUB kernel size as we did in the past. So, due to
these reasons I would stick with grub-core/kern/misc.c for grub_strtok()
and grub_strtok_r().
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2025-08-04 18:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 1:54 [PATCH v5 0/5] Add commands to load BLS and UKI files Alec Brown via Grub-devel
2025-07-27 1:54 ` [PATCH v5 1/5] kern/misc: Implement grub_strtok() Alec Brown via Grub-devel
2025-07-28 13:21 ` Frediano Ziglio via Grub-devel
2025-08-01 13:03 ` Daniel Kiper via Grub-devel
2025-08-01 12:58 ` Daniel Kiper via Grub-devel
2025-08-01 13:51 ` Vladimir 'phcoder' Serbinenko
2025-08-04 16:40 ` Daniel Kiper via Grub-devel [this message]
2025-07-27 1:54 ` [PATCH v5 2/5] blsuki: Add blscfg command to parse Boot Loader Specification snippets Alec Brown via Grub-devel
2025-08-04 18:14 ` Daniel Kiper via Grub-devel
2025-07-27 1:54 ` [PATCH v5 3/5] util/misc.c: Change offset type for grub_util_write_image_at() Alec Brown via Grub-devel
2025-08-04 18:16 ` Daniel Kiper via Grub-devel
2025-07-27 1:54 ` [PATCH v5 4/5] blsuki: Check for mounted /boot in emu Alec Brown via Grub-devel
2025-08-04 18:31 ` Daniel Kiper via Grub-devel
2025-07-27 1:54 ` [PATCH v5 5/5] blsuki: Add uki command to load Unified Kernel Image entries Alec Brown via Grub-devel
2025-08-05 14:34 ` Daniel Kiper via Grub-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJDigmQQFibiMmop@tomti.i.net-space.pl \
--to=grub-devel@gnu.org \
--cc=93sam@debian.org \
--cc=alec.r.brown@oracle.com \
--cc=christopher.obbard@linaro.org \
--cc=daniel.kiper@oracle.com \
--cc=jan.setjeeilers@oracle.com \
--cc=lsandova@redhat.com \
--cc=mate.kukri@canonical.com \
--cc=mlewando@redhat.com \
--cc=phcoder@gmail.com \
--cc=pjones@redhat.com \
--cc=ross.philipson@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.