From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 6/6] Add file_attr03 test
Date: Tue, 5 Aug 2025 14:22:42 +0200 [thread overview]
Message-ID: <aJH3kho29ad5UY58@yuki.lan> (raw)
In-Reply-To: <20250805-file_setattr_getattr-v3-6-67a7747d226c@suse.com>
Hi!
> +static void run(void)
> +{
> + dfd = SAFE_OPEN(MNTPOINT, O_DIRECTORY);
> + fd = SAFE_CREAT(MNTPOINT "/" FILENAME, 0777);
> +
> + TST_EXP_PASS(file_setattr(dfd, FILENAME, attr, FILE_ATTR_SIZE_LATEST, 0));
^
Just for a completion I would use
AT_FDCWD in this test so that we test
both dirfd (in previous test) and
AT_FDCWD (in this test)
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-08-05 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 7:01 [LTP] [PATCH v3 0/6] file_setattr/file_getattr testing suite Andrea Cervesato
2025-08-05 7:01 ` [LTP] [PATCH v3 1/6] Update LTP to the latest syscalls Andrea Cervesato
2025-08-05 7:01 ` [LTP] [PATCH v3 2/6] fs: add struct fsxattr fallback definitions Andrea Cervesato
2025-08-05 7:01 ` [LTP] [PATCH v3 3/6] fs: add file_setattr/file_getattr " Andrea Cervesato
2025-08-05 7:01 ` [LTP] [PATCH v3 4/6] Add file_attr01 test Andrea Cervesato
2025-08-05 11:36 ` Cyril Hrubis
2025-08-05 7:01 ` [LTP] [PATCH v3 5/6] Add file_attr02 test Andrea Cervesato
2025-08-05 11:41 ` Cyril Hrubis
2025-08-05 7:01 ` [LTP] [PATCH v3 6/6] Add file_attr03 test Andrea Cervesato
2025-08-05 12:22 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJH3kho29ad5UY58@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.