From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Konrad Dybcio" <konradybcio@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>, "Sven Peter" <sven@kernel.org>,
"Janne Grunau" <j@jannau.net>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Neal Gompa" <neal@gompa.dev>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Eugeniy Paltsev" <Eugeniy.Paltsev@synopsys.com>,
"Viresh Kumar" <vireshk@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>, "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Taichi Sugaya" <sugaya.taichi@socionext.com>,
"Takao Orito" <orito.takao@socionext.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Amélie Delaunay" <amelie.delaunay@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Peter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Michal Simek" <michal.simek@amd.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Mukesh Kumar Savaliya" <quic_msavaliy@quicinc.com>,
"Viken Dadhaniya" <quic_vdadhani@quicinc.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
imx@lists.linux.dev, linux-actions@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH RFC 3/6] dmaengine: qcom: gpi: Accept protocol ID hints
Date: Wed, 6 Aug 2025 01:08:06 +0300 [thread overview]
Message-ID: <aJKAxkXO7csIi5Oi@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdV0JO=qtregrrHsBZ-6tpNdPUj3G1_LWRfRsj0vBb+qyw@mail.gmail.com>
On Wed, Jul 30, 2025 at 01:32:58PM +0200, Geert Uytterhoeven wrote:
> On Wed, 30 Jul 2025 at 11:35, Konrad Dybcio <konradybcio@kernel.org> wrote:
...
> > + /* The protocol ID is in the teens range, simply ignore the higher bits */
> > + gchan->protocol = (u32)((u64)proto);
>
> A single cast "(uintptr_t)" should be sufficient.
FWIW, this means (unsigned long) as Torvalds is quite against uintptr_t in the kernel.
> Casing the pointer to u64 on 32-bit may trigger:
>
> warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
>
> > return dma_get_slave_channel(&gchan->vc.chan);
> > }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-05 22:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 9:33 [RFC PATCH 0/6] Allow DMA consumers to pass a cookie to providers' of_xlate Konrad Dybcio
2025-07-30 9:33 ` [PATCH RFC 1/6] dt-bindings: dma: qcom,gpi: Retire passing the protocol ID Konrad Dybcio
2025-07-30 23:46 ` Rob Herring
2025-08-01 11:36 ` Konrad Dybcio
2025-07-30 9:33 ` [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate Konrad Dybcio
2025-07-30 16:39 ` Frank Li
2025-07-30 18:04 ` Laurent Pinchart
2025-07-30 18:37 ` Frank Li
2025-08-01 12:00 ` Laurent Pinchart
2025-08-02 12:37 ` Konrad Dybcio
2025-08-04 23:51 ` Laurent Pinchart
2025-08-05 14:04 ` Konrad Dybcio
2025-07-30 19:43 ` kernel test robot
2025-07-30 20:05 ` kernel test robot
2025-07-30 9:33 ` [PATCH RFC 3/6] dmaengine: qcom: gpi: Accept protocol ID hints Konrad Dybcio
2025-07-30 11:32 ` Geert Uytterhoeven
2025-08-02 12:39 ` Konrad Dybcio
2025-08-05 22:08 ` Andy Shevchenko [this message]
2025-07-30 9:33 ` [PATCH RFC 4/6] i2c: qcom-geni: Hint GENI protocol ID to GPI DMA Konrad Dybcio
2025-07-30 9:33 ` [PATCH RFC 5/6] spi: geni-qcom: " Konrad Dybcio
2025-07-30 10:19 ` Mark Brown
2025-07-30 9:33 ` [PATCH RFC 6/6] arm64: dts: qcom: x1e80100: Remove GENI protocol ID from DMA cells Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJKAxkXO7csIi5Oi@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Frank.Li@nxp.com \
--cc=afaerber@suse.de \
--cc=alexandre.torgue@foss.st.com \
--cc=alyssa@rosenzweig.io \
--cc=amelie.delaunay@foss.st.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=haojian.zhuang@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=j@jannau.net \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=magnus.damm@gmail.com \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=neal@gompa.dev \
--cc=orito.takao@socionext.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=povik+lin@cutebit.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=saravanak@google.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sugaya.taichi@socionext.com \
--cc=sven@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.