From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>, "Mads Ynddal" <mads@ynddal.dk>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 5/6] tracetool: add test suite for tracetool with reference output
Date: Wed, 6 Aug 2025 17:47:00 +0100 [thread overview]
Message-ID: <aJOG8CsTQvp3Jcec@redhat.com> (raw)
In-Reply-To: <24abd83e-aa9e-4f02-b391-178249e9bdf5@redhat.com>
On Wed, Aug 06, 2025 at 04:58:26PM +0200, Paolo Bonzini wrote:
> On 8/6/25 12:24, Daniel P. Berrangé wrote:
> > +#line 48 "../../../../../../../../dev/stdout"
>
> These line directives depend on the name of the QEMU build directory...
>
> > + args += [events,
> > + "/dev/stdout"]
>
> ... because you're using an absolute path here.
>
> Maybe you can use a temporary directory, in which you copy the source file
> as well?
The other issue is that this will be unlikely to work on
Windows which lacks /dev/stdout. The easy solution to both
these problems is to make tracetool accept "-" as a shorthand
for stdout, in keeping with traditional UNIX tools.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-08-06 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 10:24 [PATCH v2 0/6] tracetool: add test suite to improve reviewability Daniel P. Berrangé
2025-08-06 10:24 ` [PATCH v2 1/6] checkpatch: cull trailing '*/' in SPDX check Daniel P. Berrangé
2025-08-06 10:24 ` [PATCH v2 2/6] tracetool: eliminate trailing whitespace in C format Daniel P. Berrangé
2025-08-06 10:24 ` [PATCH v2 3/6] tracetool: avoid space after "*" in arg types Daniel P. Berrangé
2025-08-06 10:24 ` [PATCH v2 4/6] tracetool: include SPDX-License-Identifier in generated files Daniel P. Berrangé
2025-08-06 10:24 ` [PATCH v2 5/6] tracetool: add test suite for tracetool with reference output Daniel P. Berrangé
2025-08-06 11:20 ` Markus Armbruster
2025-08-06 11:39 ` Daniel P. Berrangé
2025-08-06 14:58 ` Paolo Bonzini
2025-08-06 16:47 ` Daniel P. Berrangé [this message]
2025-08-06 10:24 ` [PATCH v2 6/6] tracetool: drop the probe "__nocheck__" wrapping Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJOG8CsTQvp3Jcec@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=mads@ynddal.dk \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.