Re: [nft PATCH 6/6] Makefile: Enable support for 'make check'

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Aug 01, 2025 at 06:11:05PM +0200, Phil Sutter wrote:
> Add the various testsuite runners to TESTS variable and have make call
> them with RUN_FULL_TESTSUITE=1 env var.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
>  Makefile.am | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Makefile.am b/Makefile.am
> index ba09e7f0953d5..4fb75b85a5d59 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -409,5 +409,11 @@ EXTRA_DIST += \
>  	tests \
>  	$(NULL)
>  
> +AM_TESTS_ENVIRONMENT = RUN_FULL_TESTSUITE=1; export RUN_FULL_TESTSUITE;

I use make distcheck to build the tarballs.

I would prefer not to run the tests at the time of the release
process, I always do this before release, but I prefer not to inline
this to the release process.

Maybe we can make this work this way?

  export RUN_FULL_TESTSUITE=1; make check

so make check is no-op without this variable?

Does this make sense to you?

> +TESTS = tests/json_echo/run-test.py \
> +	tests/monitor/run-tests.sh \
> +	tests/py/nft-test.py \
> +	tests/shell/run-tests.sh

BTW, there are also tests/build/ that are slow but useful, that helped
me find this:

https://git.netfilter.org/nftables/commit/?id=0584f1c1c2073ff082badc7b49ed667de41002d9

Thanks.

>  pkgconfigdir = $(libdir)/pkgconfig
>  pkgconfig_DATA = libnftables.pc
> -- 
> 2.49.0
>