From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6775CC87FD3 for ; Wed, 6 Aug 2025 19:13:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ujjZg-0008CL-FV; Wed, 06 Aug 2025 15:13:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujjZd-0008Bg-IC for qemu-devel@nongnu.org; Wed, 06 Aug 2025 15:13:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujjZa-0005vo-SQ for qemu-devel@nongnu.org; Wed, 06 Aug 2025 15:13:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754507593; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=PBbD/T3QrLRDhD3FxF7J1bhMbiv5Cg9eGn7OtcX9EwU=; b=FuH0p9xcGh31xPXCnDKVWIeshGebYySzsA2dPQbXW7DwplheB3qNtoSbdRttCu3jNXcSaB DRnlGSlRIIlRGTsKAT9eb7yGvmBHyRTu1SMXw9TpMVq746aQXnEiyf0zWFbZfFY3x1lW42 ZHAtnlo3ANHdQbgmmhQFk931acaLAXo= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-eDLMycKfOuquO88hn66BBA-1; Wed, 06 Aug 2025 15:13:09 -0400 X-MC-Unique: eDLMycKfOuquO88hn66BBA-1 X-Mimecast-MFC-AGG-ID: eDLMycKfOuquO88hn66BBA_1754507588 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CCC1180034F; Wed, 6 Aug 2025 19:13:08 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.15]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7DEB9195608F; Wed, 6 Aug 2025 19:13:06 +0000 (UTC) Date: Wed, 6 Aug 2025 20:13:03 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Tanish Desai Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, Mads Ynddal , Stefan Hajnoczi Subject: Re: [PATCH v2 1/2] tracetool: add CHECK_TRACE_EVENT_GET_STATE Message-ID: References: <20250806150539.2871-1-tanishdesai37@gmail.com> <20250806150539.2871-2-tanishdesai37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250806150539.2871-2-tanishdesai37@gmail.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Aug 06, 2025 at 03:05:38PM +0000, Tanish Desai wrote: > New attributed added in backends > CHECK_TRACE_EVENT_GET_STATE which when > present and is True wraps the code generated > by generate function in check_trace_event_get_state > check else it is outside the conditional block. > > Signed-off-by: Tanish Desai > --- > scripts/tracetool/__init__.py | 1 - > scripts/tracetool/backend/__init__.py | 26 ++++++++++++++++------- > scripts/tracetool/format/h.py | 30 ++++++++++----------------- > 3 files changed, 30 insertions(+), 27 deletions(-) > > diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py > index 2ae2e562d6..d0a02c45d7 100644 > --- a/scripts/tracetool/__init__.py > +++ b/scripts/tracetool/__init__.py > @@ -332,7 +332,6 @@ def formats(self): > return self._FMT.findall(self.fmt) > > QEMU_TRACE = "trace_%(name)s" > - QEMU_TRACE_NOCHECK = "_nocheck__" + QEMU_TRACE This is just removing obsolete code > QEMU_TRACE_TCG = QEMU_TRACE + "_tcg" > QEMU_DSTATE = "_TRACE_%(NAME)s_DSTATE" > QEMU_BACKEND_DSTATE = "TRACE_%(NAME)s_BACKEND_DSTATE" > diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py > index ea126b07ea..0ceb49eef5 100644 > --- a/scripts/tracetool/format/h.py > +++ b/scripts/tracetool/format/h.py > @@ -59,33 +59,25 @@ def generate(events, backend, group): > > out(' false)') > > - # tracer without checks > out('', > 'static inline void %(api)s(%(args)s)', > '{', > - api=e.api(e.QEMU_TRACE_NOCHECK), > + api=e.api(), > args=e.args) This bit is removing more obsolete code > > if "disable" not in e.properties: > - backend.generate(e, group) > - > + backend.generate(e, group, check_trace_event_get_state=False) > + > + if backend.check_trace_event_get_state: > + if "disable" not in e.properties: > + event_id = 'TRACE_' + e.name.upper() > + cond = "trace_event_get_state(%s)" % event_id > + out(' if (%(cond)s) {', > + cond=cond) > + backend.generate(e, group, check_trace_event_get_state=True) > + out(' }') > out('}') This is the actual new functionality > > - cond = "true" > - > - out('', > - 'static inline void %(api)s(%(args)s)', > - '{', > - ' if (%(cond)s) {', > - ' %(api_nocheck)s(%(names)s);', > - ' }', > - '}', > - api=e.api(), > - api_nocheck=e.api(e.QEMU_TRACE_NOCHECK), > - args=e.args, > - names=", ".join(e.args.names()), > - cond=cond) > - This is further obsolete code. It is best to have new functionality added in a separate commit from the removal of obsolete code. I've co-incidentally got removal of this obsolete code in the tracing test suite series I posted, so one will need to be rebased on top of the other, depending on what order Stefan wants to take the patches. > backend.generate_end(events, group) > > out('#endif /* TRACE_%s_GENERATED_TRACERS_H */' % group.upper()) > -- > 2.34.1 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|