From: Kris Van Hees <kris.van.hees@oracle.com>
To: Eugene Loh <eugene.loh@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] vars; ensure 'cwd' and 'root' work and test other inline vars
Date: Wed, 6 Aug 2025 19:33:42 -0400 [thread overview]
Message-ID: <aJPmVjXFp5PTwtMD@oracle.com> (raw)
In-Reply-To: <4768c6ab-2b0a-f21d-85c1-c434d25adbab@oracle.com>
On Wed, Aug 06, 2025 at 07:22:17PM -0400, Eugene Loh wrote:
> Reviewed-by: Eugene Loh <eugene.loh@oracle.com>
> Should an Orabug: be included? (maybe not... figured I'd ask)
> Also...
>
> On 8/6/25 18:25, Kris Van Hees wrote:
> > + /*
> > + * Copy the result into dnp (register value and tstring). We need to
> > + * clear the tstring from tnp once we move it to dnp.
> > + */
> > dnp->dn_reg = inp->din_root->dn_reg;
> > + dnp->dn_tstring = inp->din_root->dn_tstring;
> > + inp->din_root->dn_tstring;
>
> That last line should be removed?
Woops, that ought to be = NULL; Will fix and send v2.
prev parent reply other threads:[~2025-08-06 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 22:25 [PATCH] vars; ensure 'cwd' and 'root' work and test other inline vars Kris Van Hees
2025-08-06 23:22 ` Eugene Loh
2025-08-06 23:33 ` Kris Van Hees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJPmVjXFp5PTwtMD@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.