From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_socket: remove WARN_ON_ONCE with giant cgroup tree
Date: Thu, 7 Aug 2025 12:37:08 +0200 [thread overview]
Message-ID: <aJSBzdY6FvFHvhZ9@strlen.de> (raw)
In-Reply-To: <20250807100516.1380006-1-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> syzbot managed to reach this WARN_ON_ONCE with a giant cgroup tree,
> remove it.
>
> WARNING: CPU: 0 PID: 5853 at net/netfilter/nft_socket.c:220 nft_socket_init+0x2f4/0x3d0 net/netfilter/nft_socket.c:220
I looked at the repro and as far as i could see it just passes
a large NFTA_SOCKET_LEVEL attribute value.
I'd propose:
syzbot managed to reach this WARN_ON_ONCE by passing a huge level
value, remove it.
Patch is correct though.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2025-08-07 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 10:05 [PATCH nf] netfilter: nft_socket: remove WARN_ON_ONCE with giant cgroup tree Pablo Neira Ayuso
2025-08-07 10:37 ` Florian Westphal [this message]
2025-08-07 11:14 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJSBzdY6FvFHvhZ9@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.