Re: [PATCH v2 2/2] drm/xe: Update function names for GT specific workarounds

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Aug 07, 2025 at 02:42:24PM -0700, Matt Atwood wrote:
> Now that there distinctly different OOB functions, update the names to
> reflect the IPs they interact with.
> 
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushing soon to drm-xe-next

> ---
>  drivers/gpu/drm/xe/xe_gt.c |  4 ++--
>  drivers/gpu/drm/xe/xe_wa.c | 10 +++++-----
>  drivers/gpu/drm/xe/xe_wa.h |  4 ++--
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 43f2da27d9d9..a3397f04abcc 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -400,7 +400,7 @@ int xe_gt_init_early(struct xe_gt *gt)
>  
>  	xe_reg_sr_init(&gt->reg_sr, "GT", gt_to_xe(gt));
>  
> -	err = xe_wa_init(gt);
> +	err = xe_wa_gt_init(gt);
>  	if (err)
>  		return err;
>  
> @@ -408,7 +408,7 @@ int xe_gt_init_early(struct xe_gt *gt)
>  	if (err)
>  		return err;
>  
> -	xe_wa_process_oob(gt);
> +	xe_wa_process_gt_oob(gt);
>  
>  	xe_force_wake_init_gt(gt, gt_to_fw(gt));
>  	spin_lock_init(&gt->global_invl_lock);
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 0fc73af1bb4c..52c7df4c3afd 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -916,13 +916,13 @@ void xe_wa_process_device_oob(struct xe_device *xe)
>  }
>  
>  /**
> - * xe_wa_process_oob - process OOB workaround table
> + * xe_wa_process_gt_oob - process GT OOB workaround table
>   * @gt: GT instance to process workarounds for
>   *
>   * Process OOB workaround table for this platform, marking in @gt the
>   * workarounds that are active.
>   */
> -void xe_wa_process_oob(struct xe_gt *gt)
> +void xe_wa_process_gt_oob(struct xe_gt *gt)
>  {
>  	struct xe_rtp_process_ctx ctx = XE_RTP_PROCESS_CTX_INITIALIZER(gt);
>  
> @@ -1006,12 +1006,12 @@ int xe_wa_device_init(struct xe_device *xe)
>  }
>  
>  /**
> - * xe_wa_init - initialize gt with workaround bookkeeping
> + * xe_wa_gt_init - initialize gt with workaround bookkeeping
>   * @gt: GT instance to initialize
>   *
>   * Returns 0 for success, negative error code otherwise.
>   */
> -int xe_wa_init(struct xe_gt *gt)
> +int xe_wa_gt_init(struct xe_gt *gt)
>  {
>  	struct xe_device *xe = gt_to_xe(gt);
>  	size_t n_oob, n_lrc, n_engine, n_gt, total;
> @@ -1037,7 +1037,7 @@ int xe_wa_init(struct xe_gt *gt)
>  
>  	return 0;
>  }
> -ALLOW_ERROR_INJECTION(xe_wa_init, ERRNO); /* See xe_pci_probe() */
> +ALLOW_ERROR_INJECTION(xe_wa_gt_init, ERRNO); /* See xe_pci_probe() */
>  
>  void xe_wa_device_dump(struct xe_device *xe, struct drm_printer *p)
>  {
> diff --git a/drivers/gpu/drm/xe/xe_wa.h b/drivers/gpu/drm/xe/xe_wa.h
> index 105497c1d7d7..6a869b2de643 100644
> --- a/drivers/gpu/drm/xe/xe_wa.h
> +++ b/drivers/gpu/drm/xe/xe_wa.h
> @@ -14,9 +14,9 @@ struct xe_hw_engine;
>  struct xe_tile;
>  
>  int xe_wa_device_init(struct xe_device *xe);
> -int xe_wa_init(struct xe_gt *gt);
> +int xe_wa_gt_init(struct xe_gt *gt);
>  void xe_wa_process_device_oob(struct xe_device *xe);
> -void xe_wa_process_oob(struct xe_gt *gt);
> +void xe_wa_process_gt_oob(struct xe_gt *gt);
>  void xe_wa_process_gt(struct xe_gt *gt);
>  void xe_wa_process_engine(struct xe_hw_engine *hwe);
>  void xe_wa_process_lrc(struct xe_hw_engine *hwe);
> -- 
> 2.49.0
>