All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: Yong Huang <yong.huang@smartx.com>,
	Lukas Straub <lukasstraub2@web.de>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] multifd: Make the main thread yield periodically to the main loop
Date: Fri, 8 Aug 2025 11:37:23 -0400	[thread overview]
Message-ID: <aJYZs9NnAOqVMcd1@x1.local> (raw)
In-Reply-To: <87o6sp2a0i.fsf@suse.de>

On Fri, Aug 08, 2025 at 10:55:25AM -0300, Fabiano Rosas wrote:
> Please work with Lukas to figure out whether yank can be used here. I
> think that's the correct approach. If the main loop is blocked, then
> some out-of-band cancellation routine is needed. migrate_cancel() could
> be it, but at the moment it's not. Yank is the second best thing.

I agree.

migrate_cancel() should really be an OOB command..  It should be a superset
of yank features, plus anything migration speficic besides yanking the
channels, for example, when migration thread is blocked in PRE_SWITCHOVER.

I'll add this into my todo; maybe I can do something with it this release.
I'm happy if anyone would beat me to it.

> 
> The need for a timeout is usually indicative of a design issue. In this
> case, the choice of a coroutine for the incoming side is the obvious
> one. Peter will tell you all about it! =)

Nah. :)

-- 
Peter Xu



  reply	other threads:[~2025-08-08 15:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07  2:41 [PATCH] multifd: Make the main thread yield periodically to the main loop yong.huang
2025-08-07  9:32 ` Lukas Straub
2025-08-07  9:36 ` Lukas Straub
2025-08-08  2:36   ` Yong Huang
2025-08-08  7:01     ` Lukas Straub
2025-08-08  8:02       ` Yong Huang
2025-08-08 13:55         ` Fabiano Rosas
2025-08-08 15:37           ` Peter Xu [this message]
2025-08-11  2:25             ` Yong Huang
2025-08-11  7:03             ` Lukas Straub
2025-08-11 13:53               ` Fabiano Rosas
2025-08-19 10:31                 ` Daniel P. Berrangé
2025-08-19 12:03                   ` Lukas Straub
2025-08-19 12:07                     ` Daniel P. Berrangé
2025-08-19 20:03                       ` Peter Xu
2025-08-11  2:27           ` Yong Huang
2025-08-08  6:36 ` Yong Huang
2025-08-08 15:42 ` Peter Xu
2025-08-11  2:02   ` Yong Huang
2025-08-19 10:19 ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJYZs9NnAOqVMcd1@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=lukasstraub2@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=yong.huang@smartx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.