From: dmkhn@proton.me
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
anthony.perard@vates.tech, jbeulich@suse.com,
michal.orzel@amd.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com
Subject: Re: [PATCH v14 3/4] tools/tests: introduce unit tests for domain ID allocator
Date: Sat, 09 Aug 2025 17:04:02 +0000 [thread overview]
Message-ID: <aJd/fUPtOJNkpZsS@kraken> (raw)
In-Reply-To: <44b43350-8c0a-497d-b0b0-034a548afac0@xen.org>
On Fri, Aug 08, 2025 at 06:57:07PM +0100, Julien Grall wrote:
>
>
> On 08/08/2025 18:56, Julien Grall wrote:
> > Hi Denis,
> >
> > On 08/08/2025 03:20, dmkhn@proton.me wrote:
> >> From: Denis Mukhin <dmukhin@ford.com>
> >>
> >> Introduce some basic infrastructure for doing domain ID allocation
> >> unit tests,
> >> and add a few tests that ensure correctness of the domain ID allocator.
> >
> > I am quite happy to see more unit tests for Xen :).
> >
> >>
> >> Use <xen-tools/bitops.h> and xen/lib/find-next-bit.c in test hardness
> >> code.
> >>
> >> Adjust find-next-bit.c to be compiled with __XEN_TOOLS__.
> >>
> >> Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> >
> > With a couple of remarks below:
> >
> > Acked-by: Julien Grall <jgrall@amazon.com>
>
> Actually, this should have been a Reviewed-by tag. Sorry.
Thanks for review!
>
> Cheers,
>
> --
> Julien Grall
>
next prev parent reply other threads:[~2025-08-09 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 2:19 [PATCH v14 0/4] xen/domain: domain ID allocation dmkhn
2025-08-08 2:19 ` [PATCH v14 1/4] xen/domain: unify " dmkhn
2025-08-08 17:42 ` Julien Grall
2025-08-09 17:01 ` dmkhn
2025-08-08 2:20 ` [PATCH v14 2/4] tools/include: move xc_bitops.h to xen-tools/bitops.h dmkhn
2025-08-08 2:20 ` [PATCH v14 3/4] tools/tests: introduce unit tests for domain ID allocator dmkhn
2025-08-08 17:56 ` Julien Grall
2025-08-08 17:57 ` Julien Grall
2025-08-09 17:04 ` dmkhn [this message]
2025-08-09 17:03 ` dmkhn
2025-08-08 2:20 ` [PATCH v14 4/4] xen/domain: update create_dom0() messages dmkhn
2025-08-08 17:57 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJd/fUPtOJNkpZsS@kraken \
--to=dmkhn@proton.me \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmukhin@ford.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.