From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95437C87FCF for ; Sat, 9 Aug 2025 17:15:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1076159.1437881 (Exim 4.92) (envelope-from ) id 1uknA3-0001rO-BH; Sat, 09 Aug 2025 17:15:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1076159.1437881; Sat, 09 Aug 2025 17:15:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uknA3-0001rH-7B; Sat, 09 Aug 2025 17:15:15 +0000 Received: by outflank-mailman (input) for mailman id 1076159; Sat, 09 Aug 2025 17:15:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uknA2-0001rB-0U for xen-devel@lists.xenproject.org; Sat, 09 Aug 2025 17:15:14 +0000 Received: from mail-10631.protonmail.ch (mail-10631.protonmail.ch [79.135.106.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6929d338-7544-11f0-a325-13f23c93f187; Sat, 09 Aug 2025 19:15:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6929d338-7544-11f0-a325-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1754759712; x=1755018912; bh=thanlJuksLNx6tanpBgKgBiIGs9aSMKVMgh72IminGE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=b8+GPoqdm+/6I5vBnZUuonjTdbJ3Jxx/28dTIRk0/AXuKi7JaH1rPe2B2TxtZL68k ZYqenzlENMJSNJIf/f1dNuefZx7ScarLbbsnzCen/ahMyF6SFQPE0K1cyV6lSe0kV0 nvq16NQR6Yupg3z062BjOnAz3HptGiITXjj0VvltVcnD5qDgiROYvsrFlDRcROXO7l Cuocu9wv8r4JD4kVDVpXoNlCJ9zqCFGe9TVlcZAd8KBASDZvfN6f/+KeksWRqFqs9F x0VzhN9jzhYfgIobktfuyH6oaiBJDy29m60UHjuAj3iVgqX5+W+G5itroHCkZ7o4JU /qna6U3xgnGgA== Date: Sat, 09 Aug 2025 17:15:04 +0000 To: Mykola Kvach From: dmkhn@proton.me Cc: xen-devel@lists.xenproject.org, Mykola Kvach , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: irq: add missing spin_unlock() in init_local_irq_data() error path Message-ID: In-Reply-To: References: Feedback-ID: 123220910:user:proton X-Pm-Message-ID: 03b61940d2d15721c225bcebd61a236476080a71 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Aug 09, 2025 at 05:32:41PM +0300, Mykola Kvach wrote: > From: Mykola Kvach >=20 > If init_one_irq_desc() fails, init_local_irq_data() returns without > releasing local_irqs_type_lock, leading to a possible deadlock. >=20 > Release the lock before returning to ensure proper cleanup. >=20 > Signed-off-by: Mykola Kvach Nice catch! Please consider: Reviewed-by: Denis Mukhin =20 > --- > xen/arch/arm/irq.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c > index 4bbf0b0664..02ca82c089 100644 > --- a/xen/arch/arm/irq.c > +++ b/xen/arch/arm/irq.c > @@ -94,7 +94,10 @@ static int init_local_irq_data(unsigned int cpu) > int rc =3D init_one_irq_desc(desc); >=20 > if ( rc ) > + { > + spin_unlock(&local_irqs_type_lock); > return rc; > + } >=20 > desc->irq =3D irq; > desc->action =3D NULL; > -- > 2.48.1 >=20 >=20