From: Patrick Steinhardt <ps@pks.im>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/2] t/unit-tests/clar: fix -Wmaybe-uninitialized with -Og
Date: Mon, 11 Aug 2025 11:00:03 +0200 [thread overview]
Message-ID: <aJmxExJgFKxeiHDf@pks.im> (raw)
In-Reply-To: <aJWtbGGBOELZN6tp@generichostname>
On Fri, Aug 08, 2025 at 12:55:24AM -0700, Denton Liu wrote:
> On Fri, Aug 08, 2025 at 07:48:10AM +0200, Patrick Steinhardt wrote:
> > On Mon, Aug 04, 2025 at 10:31:16PM -0700, Denton Liu wrote:
> > > When building with -Og on gcc 15.1.1, the build produces a warning. In
> > > practice, though, this cannot be hit because `exact` acts as a guard and
> > > that variable can only be set after `matchlen` is already initialized
> > >
> > > Assign a default value to `matchlen` so that the warning is silenced.
> >
> > Would you mind creating a PR against upstream [1] so that we also have it
> > over there? Thanks!
>
> Good idea. PR over at [0]
>
> -Denton
>
> [0]: https://github.com/clar-test/clar/pull/119
Thanks, approved and merged now.
Patrick
prev parent reply other threads:[~2025-08-11 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 10:07 [PATCH] fix -Wmaybe-uninitialized with -Og Denton Liu
2025-08-04 13:19 ` Jeff King
2025-08-04 13:46 ` Junio C Hamano
2025-08-04 15:53 ` Jeff King
2025-08-05 5:31 ` [PATCH v2 0/2] " Denton Liu
2025-08-05 5:31 ` [PATCH v2 1/2] remote: bail early from set_head() if missing remote name Denton Liu
2025-08-05 5:31 ` [PATCH v2 2/2] t/unit-tests/clar: fix -Wmaybe-uninitialized with -Og Denton Liu
2025-08-08 5:48 ` Patrick Steinhardt
2025-08-08 7:55 ` Denton Liu
2025-08-11 9:00 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJmxExJgFKxeiHDf@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.