From: Leo Liang <ycliang@andestech.com>
To: Yixun Lan <dlan@gentoo.org>
Cc: Niu Zhihong <zhihong@nzhnb.com>, <u-boot@lists.denx.de>,
<spacemit@lists.linux.dev>
Subject: Re: [PATCH] board: spacemit: Add SpacemiT MUSE Pi Pro
Date: Mon, 11 Aug 2025 19:47:15 +0800 [thread overview]
Message-ID: <aJnYQyfeWBaln8ff@swlinux02> (raw)
In-Reply-To: <20250728100607-GYA777015@gentoo>
On Mon, Jul 28, 2025 at 06:06:07PM +0800, Yixun Lan wrote:
> [EXTERNAL MAIL]
>
> Hi Niu,
>
> You need to split the patch, and prepare a cover letter..
>
> Have to say, generally, this patch isn't really different comparing
> with current in tree bananapi-f3, so neither it is useful..
>
> I personally would expect to see more drivers support for K1 SoC,
> then figure out how to have more boards enabled..
> (I'd propose to not merge this patch, but if maintainer is ok with
> this, then I'd have no objection)
Hi Niu and Yixun,
I am OK merging the patch for new board,
but as Yixun and Yao's suggestion,
there are some modifications need to be made.
Please follow the advice and re-spin a patchset, thanks!
Best regards,
Leo
>
> CC spacemit mailing list for more wide comments
>
> On 16:25 Mon 28 Jul , Niu Zhihong wrote:
> > MUSE Pi Pro uses spacemit K1,
> > a new generation of octa-core 64-bit RISC-V processor,
> > which includes octa-core X60.
> >
> > Features tested on a MUSE Pi Pro 16GB:
> > - SD-card boot
> > - eMMC boot
> this brings some confusions, as currently there is no SD/eMMC driver support
> for K1, only means it's able to boot from SD/eMMC (with brom support)
>
> >
> > Signed-off-by: Niu Zhihong <zhihong@nzhnb.com>
> > ---
> > arch/riscv/Kconfig | 4 ++
> > arch/riscv/dts/Makefile | 1 +
> > arch/riscv/dts/k1-muse-pi-pro.dts | 27 ++++++++
> > board/spacemit/muse-pi-pro/Kconfig | 37 +++++++++++
> > board/spacemit/muse-pi-pro/MAINTAINERS | 6 ++
> > board/spacemit/muse-pi-pro/Makefile | 3 +
> > board/spacemit/muse-pi-pro/board.c | 8 +++
> > configs/muse-pi-pro_defconfig | 6 ++
> > doc/board/spacemit/index.rst | 1 +
> > doc/board/spacemit/muse-pi-pro.rst | 85 ++++++++++++++++++++++++++
> > include/configs/muse-pi-pro.h | 11 ++++
> > 11 files changed, 189 insertions(+)
> > create mode 100644 arch/riscv/dts/k1-muse-pi-pro.dts
> > create mode 100644 board/spacemit/muse-pi-pro/Kconfig
> > create mode 100644 board/spacemit/muse-pi-pro/MAINTAINERS
> > create mode 100644 board/spacemit/muse-pi-pro/Makefile
> > create mode 100644 board/spacemit/muse-pi-pro/board.c
> > create mode 100644 configs/muse-pi-pro_defconfig
> > create mode 100644 doc/board/spacemit/muse-pi-pro.rst
> > create mode 100644 include/configs/muse-pi-pro.h
prev parent reply other threads:[~2025-08-11 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 8:25 [PATCH] board: spacemit: Add SpacemiT MUSE Pi Pro Niu Zhihong
2025-07-28 9:58 ` Yao Zi
2025-07-28 10:06 ` Yixun Lan
2025-08-11 11:47 ` Leo Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJnYQyfeWBaln8ff@swlinux02 \
--to=ycliang@andestech.com \
--cc=dlan@gentoo.org \
--cc=spacemit@lists.linux.dev \
--cc=u-boot@lists.denx.de \
--cc=zhihong@nzhnb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.