All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Luca Weiss <luca@lucaweiss.eu>
Cc: Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Robert Foss <rfoss@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] i2c: qcom-cci: Add msm8953 compatible
Date: Mon, 11 Aug 2025 14:13:50 +0200	[thread overview]
Message-ID: <aJnefpETGJm_cuRY@shikoro> (raw)
In-Reply-To: <20250810-msm8953-cci-v1-2-e83f104cabfc@lucaweiss.eu>

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Sun, Aug 10, 2025 at 05:37:53PM +0200, Luca Weiss wrote:
> Add a config for the v1.2.5 CCI found on msm8953 which has different

Given the above version number...

>  static const struct of_device_id cci_dt_match[] = {
>  	{ .compatible = "qcom,msm8226-cci", .data = &cci_v1_data},
> +	{ .compatible = "qcom,msm8953-cci", .data = &cci_msm8953_data},

... why don't we use it here to stay consistent? cci_v1_2_5_data?

>  	{ .compatible = "qcom,msm8974-cci", .data = &cci_v1_5_data},
>  	{ .compatible = "qcom,msm8996-cci", .data = &cci_v2_data},

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-08-11 12:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-10 15:37 [PATCH 0/7] Camera I2C (CCI) enablement on MSM8953 and Fairphone 3 Luca Weiss
2025-08-10 15:37 ` [PATCH 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible Luca Weiss
2025-08-18 15:37   ` Rob Herring
2025-08-18 17:46     ` Luca Weiss
2025-08-10 15:37 ` [PATCH 2/7] i2c: qcom-cci: Add " Luca Weiss
2025-08-11 12:13   ` Wolfram Sang [this message]
2025-08-15  7:12     ` Luca Weiss
2025-08-15  8:31       ` Wolfram Sang
2025-08-15 11:22         ` Loic Poulain
2025-09-04 11:51       ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 3/7] dt-bindings: eeprom: at24: Add compatible for Belling BL24S64 Luca Weiss
2025-08-18 15:51   ` Rob Herring
2025-08-18 17:45     ` Luca Weiss
2025-08-25 19:51       ` Bartosz Golaszewski
2025-08-10 15:37 ` [PATCH 4/7] arm64: dts: qcom: msm8953: Re-sort tlmm pinctrl states Luca Weiss
2025-08-11 11:26   ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 5/7] arm64: dts: qcom: msm8953: Add CCI nodes Luca Weiss
2025-08-11 11:26   ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 6/7] arm64: dts: qcom: sdm632-fairphone-fp3: Add camera fixed regulators Luca Weiss
2025-08-11 11:27   ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 7/7] arm64: dts: qcom: sdm632-fairphone-fp3: Enable CCI and add EEPROM Luca Weiss
2025-08-11 11:27   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJnefpETGJm_cuRY@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=luca@lucaweiss.eu \
    --cc=phone-devel@vger.kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.