From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 455DFCA0EC4 for ; Mon, 11 Aug 2025 23:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TDhRRv/dMVFepuMLbak5aj0Cx+TF2ws3EBl8BcpmQYw=; b=budgvfc9RvDaR3oSh9gK3vtAoc vkELfQVLjZOmqGq+L0YNVfB1vkNJMj1vyiC39BY2rzukOqZLiR2n6kSuKqb7eLAkEtM8p7d9hJUTu 6351RIvnYTpflHVJxfIJoO1SQTA7WGIfptygl6PoagjWfMMfW7YuCFpgqJekjQyc3FOHkggd4w+wV YYQUnJTK4kKee0QPAhqsxxbSwg3qW2vy1hB5JtU6ajJ0NpiwS1sUbS/tMpZhWbfs6SFrwjP7Eg0rA PlqRrY772QZYRemuH8/GPfOeicmuMgN3QzmC9Si5nIMF+1rWet+1Hulrq2WJVgBmq4IQ2xBMVl6H1 EF6RQkdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulbl0-00000009MRN-46yx; Mon, 11 Aug 2025 23:16:46 +0000 Received: from mgamail.intel.com ([198.175.65.16]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulZB6-000000091Gf-1mdB for linux-arm-kernel@lists.infradead.org; Mon, 11 Aug 2025 20:31:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754944293; x=1786480293; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WAVSplizknoBUN8PWM1qGthGcY9wzNFmieVn3H5fMP0=; b=OsnITh2E0T2DgCVT/NjBiWhfGHRbkq0xIn3zuoeODO0lMz1JC7adi90w xFcX0thARYr/krpQXFm+cLuKkaDhD02Rh6tDPBVP7YBbqC67P0zO9k2Mz 81z0vzyIlOTUwV77XZy9nvayuLzWrkCDSWYeKNHnTzrAzd28UKPtx09WF A1I4BXZw98akrGIQX0iMk38CnlwBOdXQuIebaInM6v3GkQOJScyOQHX5/ afsQWEJ1y38iwl9fQlSuPPNxDX4V5sDEmIzVPVP4RyqGEZiCMVfqplH81 RPNX0wl2oe9f/GLTI5V4piKZRiwTutvjqkQQQ2GkOQpOou4yfZ9rH2m3O Q==; X-CSE-ConnectionGUID: JZzyg+anTk2D6fLtsw0cGA== X-CSE-MsgGUID: CYVts/aFSOeToGMWFl2ALQ== X-IronPort-AV: E=McAfee;i="6800,10657,11518"; a="57353672" X-IronPort-AV: E=Sophos;i="6.17,284,1747724400"; d="scan'208";a="57353672" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 13:31:32 -0700 X-CSE-ConnectionGUID: HY3ftl14RnWPgtKSiQRgoA== X-CSE-MsgGUID: hkJYL8CmRfelQVDTPhceDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,284,1747724400"; d="scan'208";a="170452077" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 13:31:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1ulZAy-000000056h0-1aOL; Mon, 11 Aug 2025 23:31:24 +0300 Date: Mon, 11 Aug 2025 23:31:24 +0300 From: Andy Shevchenko To: Gabor Juhos Cc: Wolfram Sang , Wolfram Sang , Andi Shyti , Russell King , Andrew Lunn , Hanna Hawa , Robert Marko , Linus Walleij , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Imre Kaloz , stable@vger.kernel.org Subject: Re: [PATCH v2 3/3] i2c: pxa: handle 'Early Bus Busy' condition on Armada 3700 Message-ID: References: <20250811-i2c-pxa-fix-i2c-communication-v2-0-ca42ea818dc9@gmail.com> <20250811-i2c-pxa-fix-i2c-communication-v2-3-ca42ea818dc9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250811-i2c-pxa-fix-i2c-communication-v2-3-ca42ea818dc9@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250811_133132_679443_6FD15C48 X-CRM114-Status: GOOD ( 35.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 11, 2025 at 09:49:57PM +0200, Gabor Juhos wrote: > Under some circumstances I2C recovery fails on Armada 3700. At least > on the Methode uDPU board, removing and replugging an SFP module fails > often, like this: > > [ 36.953127] sfp sfp-eth1: module removed > [ 38.468549] i2c i2c-1: i2c_pxa: timeout waiting for bus free > [ 38.486960] sfp sfp-eth1: module MENTECHOPTO POS22-LDCC-KR rev 1.0 sn MNC208U90009 dc 200828 > [ 38.496867] mvneta d0040000.ethernet eth1: unsupported SFP module: no common interface modes > [ 38.521448] hwmon hwmon2: temp1_input not attached to any thermal zone > [ 39.249196] sfp sfp-eth1: module removed > ... > [ 292.568799] sfp sfp-eth1: please wait, module slow to respond > ... > [ 625.208814] sfp sfp-eth1: failed to read EEPROM: -EREMOTEIO > > Note that the 'unsupported SFP module' messages are not relevant. The > module is used only for testing the I2C recovery funcionality, because > the error can be triggered easily with this specific one. > > Enabling debug in the i2c-pxa driver reveals the following: > > [ 82.034678] sfp sfp-eth1: module removed > [ 90.008654] i2c i2c-1: slave_0x50 error: timeout with active message > [ 90.015112] i2c i2c-1: msg_num: 2 msg_idx: 0 msg_ptr: 0 > [ 90.020464] i2c i2c-1: IBMR: 00000003 IDBR: 000000a0 ICR: 000007e0 ISR: 00000802 > [ 90.027906] i2c i2c-1: log: > [ 90.030787] > > This continues until the retries are exhausted ... > > [ 110.192489] i2c i2c-1: slave_0x50 error: exhausted retries > [ 110.198012] i2c i2c-1: msg_num: 2 msg_idx: 0 msg_ptr: 0 > [ 110.203323] i2c i2c-1: IBMR: 00000003 IDBR: 000000a0 ICR: 000007e0 ISR: 00000802 > [ 110.210810] i2c i2c-1: log: > [ 110.213633] > > ... then the whole sequence starts again ... > > [ 115.368641] i2c i2c-1: slave_0x50 error: timeout with active message > > ... while finally the SFP core gives up: > > [ 671.975258] sfp sfp-eth1: failed to read EEPROM: -EREMOTEIO > > When we analyze the log, it can be seen that bit 1 and 11 is set in the > ISR (Interface Status Register). Bit 1 indicates the ACK/NACK status, but > the purpose of bit 11 is not documented in the driver code unfortunately. > > The 'Functional Specification' document of the Armada 3700 SoCs family > however says that this bit indicates an 'Early Bus Busy' condition. The > document also notes that whenever this bit is set, it is not possible to > initiate a transaction on the I2C bus. The observed behaviour corresponds > to this statement. > > Unfortunately, I2C recovery does not help as it never runs in this > special case. Although the driver checks the busyness of the bus at > several places, but since it does not consider the A3700 specific bit > in these checks it can't determine the actual status of the bus correctly > which results in the errors above. > > In order to fix the problem, add a new member to struct 'i2c_pxa' to > store a controller specific bitmask containing the bits indicating the > busy status, and use that in the code while checking the actual status > of the bus. This ensures that the correct status can be determined on > the Armada 3700 based devices without causing functional changes on > devices based on other SoCs. > > With the change applied, the driver detects the busy condition, and runs > the recovery process: > > [ 742.617312] i2c i2c-1: state:i2c_pxa_wait_bus_not_busy:449: ISR=00000802, ICR=000007e0, IBMR=03 > [ 742.626099] i2c i2c-1: i2c_pxa: timeout waiting for bus free > [ 742.631933] i2c i2c-1: recovery: resetting controller, ISR=0x00000802 > [ 742.638421] i2c i2c-1: recovery: IBMR 0x00000003 ISR 0x00000000 > > This clears the EBB bit in the ISR register, so it makes it possible to > initiate transactions on the I2C bus again. > > After this patch, the SFP module used for testing can be removed and > replugged numerous times without causing the error described at the > beginning. Previously, the error happened after a few such attempts. > > The patch has been tested also with the following kernel versions: > 5.10.237, 5.15.182, 6.1.138, 6.6.90, 6.12.28, 6.14.6. It improves > recoverabilty on all of them. ... > Note: the patch is included in this series for completeness however > it can be applied independently from the preceding patches. On kernels > 6.3+, it restores I2C functionality even in itself because it recovers > the controller from the bad state described in the previous patch. Sounds to me like this one should be applied first independently on the discussion / conclusion on the patch 1. ... Code wise it looks reasonable to me, but I haven't reviewed it properly and wouldn't probably have a time, that's why no tags. -- With Best Regards, Andy Shevchenko