From: dmkhn@proton.me
To: Jan Beulich <jbeulich@suse.com>
Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech,
julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com,
Julien Grall <jgrall@amazon.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v15 3/4] tools/tests: introduce unit tests for domain ID allocator
Date: Mon, 11 Aug 2025 23:53:13 +0000 [thread overview]
Message-ID: <aJqCZWSLJ24Fsn+T@kraken> (raw)
In-Reply-To: <0089146c-fe86-42b5-afa7-72dffb08c3b7@suse.com>
On Mon, Aug 11, 2025 at 09:58:24AM +0200, Jan Beulich wrote:
> On 09.08.2025 19:08, dmkhn@proton.me wrote:
> > diff --git a/tools/tests/domid/include/xen/domain.h b/tools/tests/domid/include/xen/domain.h
> > new file mode 120000
> > index 000000000000..2eda9aed088e
> > --- /dev/null
> > +++ b/tools/tests/domid/include/xen/domain.h
> > @@ -0,0 +1 @@
> > +../../harness.h
> > \ No newline at end of file
>
> In the tests we generally generate symlinks as necessary, rather than having them be
> present in git. Furthermore it's not quite clear why a file of this name is needed
> in a test harness anyway. Elsewhere we adjust hypervisor sources to make respective
> #include-s conditional.
I'll fix the makefile for the test so dependencies are resolved on the fly
and no need for code adjustment.
>
> Jan
next prev parent reply other threads:[~2025-08-11 23:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 17:07 [PATCH v15 0/4] xen/domain: domain ID allocation dmkhn
2025-08-09 17:08 ` [PATCH v15 1/4] xen/domain: unify " dmkhn
2025-08-11 11:00 ` Alejandro Vallejo
2025-08-11 23:47 ` dmkhn
2025-08-11 11:14 ` Jan Beulich
2025-08-11 23:46 ` dmkhn
2025-08-09 17:08 ` [PATCH v15 2/4] tools/include: move xc_bitops.h to xen-tools/bitops.h dmkhn
2025-08-09 17:08 ` [PATCH v15 3/4] tools/tests: introduce unit tests for domain ID allocator dmkhn
2025-08-11 7:58 ` Jan Beulich
2025-08-11 23:53 ` dmkhn [this message]
2025-08-09 17:08 ` [PATCH v15 4/4] xen/domain: update create_dom0() messages dmkhn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJqCZWSLJ24Fsn+T@kraken \
--to=dmkhn@proton.me \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmukhin@ford.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.