Re: [PATCH v2 3/3] Image size checks: Simplify help text

[Philip Oberfichtner <pro@denx.de>]

On Mon, Aug 11, 2025 at 04:25:03PM +0200, Marek Vasut wrote:
> On 8/11/25 10:57 AM, Philip Oberfichtner wrote:
> > On Thu, Aug 07, 2025 at 03:41:57PM +0200, Marek Vasut wrote:
> > > On 8/7/25 12:24 PM, Philip Oberfichtner wrote:
> > > > For coherency, use the same help text for all related size checks
> > > > options. Furthermore, simplify the depends-on logic.
> > > > 
> > > > Signed-off-by: Philip Oberfichtner <pro@denx.de>
> > > > ---
> > > > 
> > > > Notes:
> > > >       Changes in v2: new
> > > > 
> > > >    Kconfig | 8 +++-----
> > > >    1 file changed, 3 insertions(+), 5 deletions(-)
> > > > 
> > > > diff --git a/Kconfig b/Kconfig
> > > > index ec20603883b..490a706101a 100644
> > > > --- a/Kconfig
> > > > +++ b/Kconfig
> > > > @@ -543,10 +543,8 @@ config BOARD_SIZE_LIMIT
> > > >    	default 1048576 if RCAR_64
> > > >    	default 0
> > > >    	help
> > > > -	  Maximum size of the U-Boot image. When defined, the build system
> > > > -	  checks that the actual size does not exceed it.  This does not
> > > > -	  include SPL nor TPL, on platforms that use that functionality, they
> > > > -	  have separate options to restrict size.
> > > > +	  Specifies the maximum length of the U-Boot image.
> > > > +	  If this value is zero, it is ignored.
> > > 
> > > This makes the description less accurate, sorry, NAK.
> > 
> > What about using just the first half:
> > 
> > 	Maximum size of the U-Boot image. When defined, the build system
> > 	checks that the actual size does not exceed it.
> > 	[plus/minus treatment of the value zero]
> > 
> > And dropping the remainder "This does not include ..."?
> Why would removing the SPL/TPL clarification be any improvement ?

This statement used to be sensible, as long as all those size limit
options were spread out over many different Kconfig files. Now having
them all together in on place, I find it rather obvious.

Furthermore, if you want maximum accuracy, you'd have to extend the text
to also include a reference to VPL and u-boot-with-spl config options.
But even then, you still won't be able to fully grasp the functioning of
BOARD_SIZE_LIMIT without consulting the Makefile.

Well, that's what I thought. If you don't agree, I'm also fine to just
leave it as is.