Re: [PATCH] tpm: prevents local DOS via tpm/tpm0/ppi/*operations

[Jarkko Sakkinen <jarkko@kernel.org>]

On Fri, Aug 08, 2025 at 02:32:02PM -0400, Denis Aleksandrov wrote:
> Ping.
> 
> Just checking in on this patch.
> It has received a "Reviewed-by" tag, and I was wondering if there is
> anything else needed from my side for it to be picked up.
> 
> Thanks,
> Denis
> 
> On Thu, Jul 3, 2025 at 8:00 AM Denis Aleksandrov <daleksan@redhat.com> wrote:
> >
> > Hi Jarkko,
> >
> > Thank you for the review. I'll add your Reviewed-by tag to my local commit.
> > Please let me know if you would like me to send a v2 version of the
> > patch with your tag included.


Hi when I tried to apply this:

~/work/kernel.org/jarkko/linux-tpmdd master* ≡ ⇡
❯ scripts/checkpatch.pl --strict  0001-tpm-prevents-local-DOS-via-tpm-tpm0-ppi-operations.patch
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#13:
Reported-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Denis Aleksandrov <daleksan@redhat.com>

WARNING: DEVICE_ATTR unusual permissions 'S_IRUSR | S_IRGRP' used
#31: FILE: drivers/char/tpm/tpm_ppi.c:348:
+static DEVICE_ATTR(tcg_operations, S_IRUSR | S_IRGRP, tpm_show_ppi_tcg_operations, NULL);

WARNING: Symbolic permissions 'S_IRUSR | S_IRGRP' are not preferred. Consider using octal permissions '0440'.
#31: FILE: drivers/char/tpm/tpm_ppi.c:348:
+static DEVICE_ATTR(tcg_operations, S_IRUSR | S_IRGRP, tpm_show_ppi_tcg_operations, NULL);

WARNING: DEVICE_ATTR unusual permissions 'S_IRUSR | S_IRGRP' used
#32: FILE: drivers/char/tpm/tpm_ppi.c:349:
+static DEVICE_ATTR(vs_operations, S_IRUSR | S_IRGRP, tpm_show_ppi_vs_operations, NULL);

WARNING: Symbolic permissions 'S_IRUSR | S_IRGRP' are not preferred. Consider using octal permissions '0440'.
#32: FILE: drivers/char/tpm/tpm_ppi.c:349:
+static DEVICE_ATTR(vs_operations, S_IRUSR | S_IRGRP, tpm_show_ppi_vs_operations, NULL);

total: 0 errors, 5 warnings, 0 checks, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

0001-tpm-prevents-local-DOS-via-tpm-tpm0-ppi-operations.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

So could you fix those up?

BR, Jarkko