From: Joe Damato <joe@dama.to>
To: Xichao Zhao <zhao.xichao@vivo.com>
Cc: ecree.xilinx@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfc: replace min/max nesting with clamp()
Date: Tue, 12 Aug 2025 11:06:28 -0700 [thread overview]
Message-ID: <aJuCpLbCbYJg_MPF@MacBook-Air.local> (raw)
In-Reply-To: <20250812065026.620115-1-zhao.xichao@vivo.com>
On Tue, Aug 12, 2025 at 02:50:26PM +0800, Xichao Zhao wrote:
> The clamp() macro explicitly expresses the intent of constraining
> a value within bounds.Therefore, replacing min(max(a, b), c) with
> clamp(val, lo, hi) can improve code readability.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> ---
> drivers/net/ethernet/sfc/efx_channels.c | 4 ++--
> drivers/net/ethernet/sfc/falcon/efx.c | 5 ++---
> drivers/net/ethernet/sfc/siena/efx_channels.c | 4 ++--
> 3 files changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2025-08-12 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 6:50 [PATCH] sfc: replace min/max nesting with clamp() Xichao Zhao
2025-08-12 18:06 ` Joe Damato [this message]
2025-08-14 13:31 ` Edward Cree
2025-08-15 1:00 ` patchwork-bot+netdevbpf
2025-08-17 14:42 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJuCpLbCbYJg_MPF@MacBook-Air.local \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.