From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 068241E9919 for ; Wed, 13 Aug 2025 07:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755071305; cv=none; b=WCgv3Wp06POawHNbKOFMnxoNVu0nW2I9fFlFeo8w/ANf9vWXDdPxJ9lri5/8nuavav1bONYvKvwMTKPJOVkZybo0UezT1E99WXov/KpT1rFus07MNIBAo1pqgc5btWD4RT7wlxxYmCQA5Sx5fT7lHucT7cHMEy8m8mfePJug6Bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755071305; c=relaxed/simple; bh=/qe7/veHT/8a86yjIcY4zZHWegwAdhC1Or/F4GIykqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MSkCyDqBq9bIilr3I2W3o67BPCeYV5FjZIBjifMpAkf07sLb1Odr9UcRX+8qj3aXCgaXeyyBicDxI/foFtgvaVr0Mt00Z4gyJ9jD/szbhAUcPvyGnPHEBMLTGle1TYP3Q3oKhoInGAvv+DoXoZgwWuruQN7pAFmZrelG2eJ1hhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QtbufPc1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QtbufPc1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49608C4CEEB; Wed, 13 Aug 2025 07:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755071304; bh=/qe7/veHT/8a86yjIcY4zZHWegwAdhC1Or/F4GIykqo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QtbufPc1P+IMRgUkqH5nA2XMUfx9CQmeb5FPgJDCAeL6MVnOFZrcR6eKdCbVXc3TM +7dRczbFXEIV3wrjEjkxD0SGSe1AIL82ANe4z5OdCLs5SzLiWdcngO17wtD3ni3eNh dr6ccJiUefTmsrFJUrk11oa/s+GRPdpk3uM/nWWVV/IGyosLyTS0HCkGrv+d/YxbID X8IwhMdxaVCXWcFY9anVd8gx6290fY1/1poc/BOKWVbtc/9akPmuGTk1crdq8YWjVi Q23+y+5AMnVxhEHBlWMqcrQL2wdoukwVQD0HhC4RJQAynJJKtHxuidAoLFpsANBzm8 dqCPwp42M521A== Date: Wed, 13 Aug 2025 10:48:21 +0300 From: Jarkko Sakkinen To: Denis Aleksandrov Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org, Jan Stancek Subject: Re: [PATCH] tpm: prevents local DOS via tpm/tpm0/ppi/*operations Message-ID: References: <20250702202851.33344-1-daleksan@redhat.com> Precedence: bulk X-Mailing-List: linux-integrity@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 12, 2025 at 05:13:32PM -0400, Denis Aleksandrov wrote: > Hi Jarkko, > > Thanks again for taking the time to review this patch. > > Regarding the `Closes:` tag warning, this issue is linked to an internal Red > Hat page, which is why  > it was omitted. Therefore, this warning might need to be ignored. > > For the other warnings, I considered using either symbolic or octal permissions > before submitting the > patch. I decided on symbolic permissions because that style is used > consistently throughout > `drivers/char/tpm/tpm_ppi.c`. > > When I tried changing the permissions to octal format, `scripts/checkpatch.pl > --strict` still flagged those > lines with the following warnings: > > ``` > WARNING: Reported-by: should be immediately followed by Closes: with a URL to > the report > #13: > Reported-by: Jan Stancek > Signed-off-by: Denis Aleksandrov Lemme check today, if I could give some feedback and help out with this. BTW could you use plain text in your emails? I know kernel people who drop automatically HTML on this address. It's cool, I'm tolerant but it's the standard :-) There's a page for this too: https://www.kernel.org/doc/html/latest/process/email-clients.html Also, vger drops HTML mails, meaning that this response will arrive there but your response that I'm responding most likely not (at least vger used behave this way). BR, Jarkko