Re: [PATCH v1] drm/xe/i2c: Introduce xe_i2c_present()

[Raag Jadav <raag.jadav@intel.com>]

On Wed, Aug 13, 2025 at 11:28:31AM +0530, Riana Tauro wrote:
> On 8/12/2025 6:35 PM, Heikki Krogerus wrote:
> > On Tue, Aug 12, 2025 at 05:56:46PM +0530, Raag Jadav wrote:
> > > In preparation of wider usecases which require checking for I2C
> > > controller presence, introduce xe_i2c_present() helper.
> > > 
> > > Suggested-by: Riana Tauro <riana.tauro@intel.com>
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > 
> > LGTM. FWIW:
> > 
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > 
> > > ---
> > >   drivers/gpu/drm/xe/xe_i2c.c | 18 ++++++++++++++++--
> > >   drivers/gpu/drm/xe/xe_i2c.h |  2 ++
> > >   2 files changed, 18 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> > > index bc7dc2099470..6534ec5de6dc 100644
> > > --- a/drivers/gpu/drm/xe/xe_i2c.c
> > > +++ b/drivers/gpu/drm/xe/xe_i2c.c
> > > @@ -146,6 +146,20 @@ static void xe_i2c_unregister_adapter(struct xe_i2c *i2c)
> > >   	fwnode_remove_software_node(i2c->adapter_node);
> > >   }
> > > +/**
> > > + * xe_i2c_present: I2C controller is present and functional
> > > + * @xe: xe device instance
> 
> '-' instead of ':' according to kernel-doc guidelines

Which means this needs to be updated file wide, but weirdly the doc parser
seems okay with it.

scripts/kernel-doc -v -none -Wall drivers/gpu/drm/xe/xe_i2c.c

> With that change
> Reviewed-by: Riana Tauro <riana.tauro@intel.com>

Awesome.

Raag