From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1524CA0EE0 for ; Wed, 13 Aug 2025 15:43:04 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1080062.1440695 (Exim 4.92) (envelope-from ) id 1umDcq-000604-D0; Wed, 13 Aug 2025 15:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1080062.1440695; Wed, 13 Aug 2025 15:42:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1umDcq-0005zx-9y; Wed, 13 Aug 2025 15:42:52 +0000 Received: by outflank-mailman (input) for mailman id 1080062; Wed, 13 Aug 2025 15:42:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1umDcp-0005zr-C7 for xen-devel@lists.xenproject.org; Wed, 13 Aug 2025 15:42:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1umDco-003Q38-1h; Wed, 13 Aug 2025 15:42:50 +0000 Received: from [2a01:cb15:80df:da00:7360:a082:15b4:b94d] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1umDco-002Z8Q-1U; Wed, 13 Aug 2025 15:42:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=WBHbdU9yu+Kf1roDgEwDVokKcjGDiNuFr0S0qRaAhGI=; b=J9h7ou7uF9e9fM7rrNehUeWZt9 Asgk8iVLKXs0CoA+KUoZT2G6pBDLaii7ONFZCYVhKqq31fYlciDZ2Gd1u56E7H/s333xQn3fzUd8E e8q1hq2BEDl6R+K8YmhUPAyQoP3JLuBM2urV7DFKKGMW26dmYePdzaTq44dD1MQ+gYK0=; Date: Wed, 13 Aug 2025 17:42:48 +0200 From: Anthony PERARD To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Anthony PERARD , Juergen Gross Subject: Re: [XEN PATCH 04/11] tools/configure: Introduce deps on json-c lib for libxl Message-ID: References: <20250808145602.41716-1-anthony@xenproject.org> <20250808145602.41716-5-anthony@xenproject.org> <5de6ae46-8398-46ab-b79a-df45358c5c30@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5de6ae46-8398-46ab-b79a-df45358c5c30@citrix.com> On Mon, Aug 11, 2025 at 11:48:19AM +0100, Andrew Cooper wrote: > On 08/08/2025 3:55 pm, Anthony PERARD wrote: > > xl: $(XL_OBJS) > > - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) -lyajl $(APPEND_LDFLAGS) > > + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(YAJL_LIBS) $(LIBJSONC_LIBS) $(APPEND_LDFLAGS) > > > > .PHONY: install > > install: all > > Specifying both isn't entirely great when one is supposed to be empty. > > Could we not have XEN_JSON_LIB(s) which is set to either $YAJL_LIBS or > $LIBJSONC_LIBS as appropriate? Yes, that sounds good. Thanks, -- Anthony PERARD