From: Dan Carpenter <dan.carpenter@linaro.org>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
audit@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] audit: add a missing tab
Date: Wed, 13 Aug 2025 18:48:23 +0300 [thread overview]
Message-ID: <aJyzxx07nycUmDde@stanley.mountain> (raw)
In-Reply-To: <9ec4a351-de59-4b6b-b200-3a2fd6cbd9a9@schaufler-ca.com>
On Wed, Aug 13, 2025 at 08:39:33AM -0700, Casey Schaufler wrote:
> On 8/12/2025 10:38 PM, Dan Carpenter wrote:
> > Someone got a bit carried away deleting tabs. Add it back.
>
> Of course, it should be the way you want it to be, but I don't
> see the reasoning. Help me understand.
>
The "call_panic = 1;" has to be indent one tab more than the
if (audit_log_pid_context()) check otherwise static checkers complain
that the if statement isn't indented.
1771 ________for (aux = context->aux_pids; aux; aux = aux->next) {
1772 ________ struct audit_aux_data_pids *axs = (void *)aux;
1773 ________
1774 ________ for (i = 0; i < axs->pid_count; i++)
1775 ________ ________if (audit_log_pid_context(context, axs->target_pid[i],
1776 ________ ________ axs->target_auid[i],
1777 ________ ________ axs->target_uid[i],
1778 ________ ________ axs->target_sessionid[i],
1779 ________ ________ &axs->target_ref[i],
1780 ________ ________ axs->target_comm[i]))
1781 ________ ________ call_panic = 1;
1782 ________}
regards,
dan carpenter
next prev parent reply other threads:[~2025-08-13 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 5:38 [PATCH] audit: add a missing tab Dan Carpenter
2025-08-13 15:39 ` Casey Schaufler
2025-08-13 15:45 ` Casey Schaufler
2025-08-13 15:48 ` Dan Carpenter [this message]
2025-08-13 15:51 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJyzxx07nycUmDde@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=audit@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=eparis@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.