From: Dan Carpenter <dan.carpenter@linaro.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, netdev@vger.kernel.org,
magnus.karlsson@intel.com, stfomichev@gmail.com,
aleksander.lobakin@intel.com,
Eryk Kubanski <e.kubanski@partner.samsung.com>
Subject: Re: [PATCH v6 bpf] xsk: fix immature cq descriptor production
Date: Tue, 26 Aug 2025 11:14:07 +0300 [thread overview]
Message-ID: <aK1sz42QLX42u6Eo@stanley.mountain> (raw)
In-Reply-To: <20250820154416.2248012-1-maciej.fijalkowski@intel.com>
On Wed, Aug 20, 2025 at 05:44:16PM +0200, Maciej Fijalkowski wrote:
> return ERR_PTR(err);
>
> skb_reserve(skb, hr);
> +
> + addrs = kmem_cache_zalloc(xsk_tx_generic_cache, GFP_KERNEL);
> + if (!addrs) {
> + kfree(skb);
This needs to be kfree_skb(skb);
regards,
dan carpenter
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + xsk_set_destructor_arg(skb, addrs);
> }
>
> addr = desc->addr;
next prev parent reply other threads:[~2025-08-26 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:44 [PATCH v6 bpf] xsk: fix immature cq descriptor production Maciej Fijalkowski
2025-08-20 17:06 ` Stanislav Fomichev
2025-08-22 16:20 ` patchwork-bot+netdevbpf
2025-08-26 8:14 ` Dan Carpenter [this message]
2025-08-26 12:23 ` Daniel Borkmann
2025-08-26 13:40 ` Jason Xing
2025-08-29 16:14 ` Maciej Fijalkowski
2025-08-30 10:32 ` Jason Xing
2025-08-26 16:00 ` Jason Xing
2025-08-26 18:23 ` Magnus Karlsson
2025-08-26 19:03 ` Maciej Fijalkowski
2025-08-26 19:13 ` Maciej Fijalkowski
2025-08-27 0:25 ` Jason Xing
-- strict thread matches above, loose matches on Subject: below --
2025-08-27 23:11 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK1sz42QLX42u6Eo@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=e.kubanski@partner.samsung.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.