Re: [PATCH 05/14] tracetool/backend: remove redundant trace event checks

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Aug 22, 2025 at 02:26:46PM +0200, Paolo Bonzini wrote:
> From: Tanish Desai <tanishdesai37@gmail.com>
> 
> Use CHECK_TRACE_EVENT_GET_STATE in log, syslog, dtrace and simple
> backend, so that the "if (trace_event_get_state)" is created from common
> code and unified when multiple backends are active.
> 
> When a single backend is active there is no code change (except
> for the log backend, as shown in tests/tracetool/log.h), but the
> code in the backends is simpler.
> 
> Signed-off-by: Tanish Desai <tanishdesai37@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/tracetool/log.h               | 16 ++++++++++------
>  scripts/tracetool/backend/ftrace.py |  6 ++----
>  scripts/tracetool/backend/log.py    | 10 ++++------
>  scripts/tracetool/backend/simple.py |  8 ++------
>  scripts/tracetool/backend/syslog.py |  8 ++------
>  5 files changed, 20 insertions(+), 28 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|