All of lore.kernel.org
 help / color / mirror / Atom feed
From: shejialuo <shejialuo@gmail.com>
To: Meet Soni <meetsoni3017@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [GSoC][PATCH 5/5] t: add test for git refs optimize subcommand
Date: Tue, 26 Aug 2025 23:18:18 +0800	[thread overview]
Message-ID: <aK3QOtQzUFsGvmyA@ArchLinux> (raw)
In-Reply-To: <20250826073645.1074397-6-meetsoni3017@gmail.com>

On Tue, Aug 26, 2025 at 01:06:45PM +0530, Meet Soni wrote:

> diff --git a/t/t1463-refs-optimize.sh b/t/t1463-refs-optimize.sh
> new file mode 100755
> index 0000000000..c11c905d79
> --- /dev/null
> +++ b/t/t1463-refs-optimize.sh
> @@ -0,0 +1,17 @@
> +#!/bin/sh
> +
> +test_description='git refs optimize should not change the branch semantic
> +
> +This test runs git refs optimize and git show-ref and checks that the branch
> +semantic is still the same.
> +'

When reading the description, I am wondering how this test runs `git
refs optimize` and `git show-ref` to achieve the goal. Should we simply
just say we use "pack-refs-tests.sh" to ensure the compatibility with
the `git pack-refs`?

> +
> +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
> +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> +GIT_TEST_DEFAULT_REF_FORMAT=files
> +export GIT_TEST_DEFAULT_REF_FORMAT
> +
> +. ./test-lib.sh
> +
> +pack_refs='refs optimize'
> +. "$TEST_DIRECTORY"/pack-refs-tests.sh
> -- 
> 2.34.1
> 

Thanks,
Jialuo

  reply	other threads:[~2025-08-26 15:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  7:36 [GSoC][PATCH 0/5] Add refs optimize subcommand Meet Soni
2025-08-26  7:36 ` [GSoC][PATCH 1/5] builtin/pack-refs: factor out core logic into a helper Meet Soni
2025-09-02 10:18   ` Patrick Steinhardt
2025-09-03  3:56     ` Meet Soni
2025-09-03  4:37       ` Patrick Steinhardt
2025-09-03  5:25     ` Junio C Hamano
2025-09-03  6:00       ` Patrick Steinhardt
2025-09-03 18:20         ` Junio C Hamano
2025-08-26  7:36 ` [GSoC][PATCH 2/5] doc: factor out common option Meet Soni
2025-08-26  7:36 ` [GSoC][PATCH 3/5] builtin/refs: add optimize subcommand Meet Soni
2025-09-02 10:18   ` Patrick Steinhardt
2025-08-26  7:36 ` [GSoC][PATCH 4/5] t0601: refactor tests to be shareable Meet Soni
2025-08-26  7:36 ` [GSoC][PATCH 5/5] t: add test for git refs optimize subcommand Meet Soni
2025-08-26 15:18   ` shejialuo [this message]
2025-08-31  6:20     ` Meet Soni
2025-09-02 10:18   ` Patrick Steinhardt
2025-09-03  3:58     ` Meet Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aK3QOtQzUFsGvmyA@ArchLinux \
    --to=shejialuo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=meetsoni3017@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.