From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Jan Engelhardt <ej@inai.de>
Subject: Re: [nft PATCH] Makefile: Fix for 'make distcheck'
Date: Wed, 27 Aug 2025 14:22:32 +0200 [thread overview]
Message-ID: <aK74iFRHm3WTCEbq@calendula> (raw)
In-Reply-To: <aK4N56uzuIWgBiG5@calendula>
On Tue, Aug 26, 2025 at 09:41:27PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Aug 26, 2025 at 07:06:43PM +0200, Phil Sutter wrote:
> > Make sure the files in tools/ are added to the tarball and that the
> > created nftables.service file is removed upon 'make clean'.
> >
> > Fixes: c4b17cf830510 ("tools: add a systemd unit for static rulesets")
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
>
> Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
I was preparing the release, however, this fix is not enough.
When I run:
make distcheck
/usr/bin/mkdir -p '/lib/systemd/system'
/usr/bin/install -c -m 644 tools/nftables.service '/lib/systemd/system'
/usr/bin/install: cannot create regular file '/lib/systemd/system/nftables.service': Permission denied
This is not regarding the _inst directory, ie. nftables-x.y.z/_inst/
that make distcheck creates as non-root.
This needs a fix.
next prev parent reply other threads:[~2025-08-27 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 17:06 [nft PATCH] Makefile: Fix for 'make distcheck' Phil Sutter
2025-08-26 19:41 ` Pablo Neira Ayuso
2025-08-27 12:22 ` Pablo Neira Ayuso [this message]
2025-08-27 12:40 ` Jan Engelhardt
2025-08-27 12:43 ` [PATCH] build: make `make distcheck` succeed in the face of absolute paths Jan Engelhardt
2025-08-27 12:57 ` Pablo Neira Ayuso
2025-08-27 21:40 ` Jan Engelhardt
2025-08-27 14:13 ` Phil Sutter
2025-08-26 21:07 ` [nft PATCH] Makefile: Fix for 'make distcheck' Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK74iFRHm3WTCEbq@calendula \
--to=pablo@netfilter.org \
--cc=ej@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.