From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D58ACA0FED for ; Wed, 27 Aug 2025 09:54:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1urCqx-0007sa-Mp; Wed, 27 Aug 2025 05:54:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urCqu-0007qs-8g for qemu-devel@nongnu.org; Wed, 27 Aug 2025 05:54:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urCqq-00049s-9B for qemu-devel@nongnu.org; Wed, 27 Aug 2025 05:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756288434; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VGYEIBPyufXUQ64aWZM9ihDU39nz1MPpC2pvFogT0oM=; b=UAkRIE3/8u6PnyvLqVt8ZUZtYudj6XKuN9FbZNoLDWXdWKAU0kFWQ76vII1YZxx5CHNm1A Ruyjj3WgPdXk8jyKTbPLJRRw7NNa6RNwFWRBvCv+80WU5VMA3aMFLUppYnRjpcLz2Z0c+1 mBNASgsQGnvu0mMeYXuveSUuxLN+CkA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-bYcoPW-OMsS5MEyFmVZH_Q-1; Wed, 27 Aug 2025 05:53:51 -0400 X-MC-Unique: bYcoPW-OMsS5MEyFmVZH_Q-1 X-Mimecast-MFC-AGG-ID: bYcoPW-OMsS5MEyFmVZH_Q_1756288430 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 43C2019560B5; Wed, 27 Aug 2025 09:53:50 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.195]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ACC7D19560AB; Wed, 27 Aug 2025 09:53:41 +0000 (UTC) Date: Wed, 27 Aug 2025 10:53:29 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Jan Kiszka Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel , Bin Meng , qemu-block@nongnu.org, Ilias Apalodimas Subject: Re: [PATCH 7/8] hw/sd/sdcard: Handle RPMB MAC field Message-ID: References: <8ea56ae040ef1037e44fc864c159e2f96f23f059.1756019920.git.jan.kiszka@siemens.com> <51a9f857-69ff-43f6-8f3d-c7e5d5870c99@linaro.org> <97fce5d7-eb6d-4698-950e-94d5468d5696@siemens.com> <2a9cddd8-2d60-4565-b6a2-de606f96b2f6@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2a9cddd8-2d60-4565-b6a2-de606f96b2f6@siemens.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Aug 27, 2025 at 07:53:12AM +0200, Jan Kiszka wrote: > On 26.08.25 12:18, Daniel P. Berrangé wrote: > > On Mon, Aug 25, 2025 at 06:30:52PM +0200, Philippe Mathieu-Daudé wrote: > >> +Dan > >> > >> On 25/8/25 18:12, Jan Kiszka wrote: > >>> On 25.08.25 11:47, Philippe Mathieu-Daudé wrote: > >>>> Hi Jan, > >>>> > >>>> On 24/8/25 09:18, Jan Kiszka wrote: > >>>>> From: Jan Kiszka > >>>>> > >>>>> Implement correct setting of the MAC field when passing RPMB frames back > >>>>> to the guest. Also check the MAC on authenticated write requests. > >>>>> > >>>>> As this depends on HMAC support for QCRYPTO_HASH_ALGO_SHA256, only > >>>>> register the eMMC class if that is available. > >>>>> > >>>>> Signed-off-by: Jan Kiszka > >>>>> --- > >>>>>   hw/sd/sd.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++- > >>>>>   1 file changed, 89 insertions(+), 1 deletion(-) > >>>> > >>>> > >>>>> @@ -3122,6 +3201,7 @@ static const TypeInfo sd_types[] = { > >>>>>           .parent         = TYPE_SD_CARD, > >>>>>           .class_init     = sd_spi_class_init, > >>>>>       }, > >>>>> +    /* must be last element */ > >>>>>       { > >>>>>           .name           = TYPE_EMMC, > >>>>>           .parent         = TYPE_SDMMC_COMMON, > >>>>> @@ -3129,4 +3209,12 @@ static const TypeInfo sd_types[] = { > >>>>>       }, > >>>>>   }; > >>>>>   -DEFINE_TYPES(sd_types) > >>>>> +static void sd_register_types(void) > >>>>> +{ > >>>>> +    int num = ARRAY_SIZE(sd_types); > >>>>> +    if (!qcrypto_hmac_supports(QCRYPTO_HASH_ALGO_SHA256)) { > >>>>> +        num--; > >>>> > >>>> Instead, expose RPMB feature in CSD when HMAC supported? > >>>> > >>>> Something in emmc_set_ext_csd() in the lines of: > >>>> > >>>>   if (qcrypto_hmac_supports(QCRYPTO_HASH_ALGO_SHA256)) { > >>>>       sd->ext_csd[EXT_CSD_REV] = 5; > >>>>       sd->ext_csd[EXT_CSD_RPMB_MULT] = sd->rpmb_part_size / (128 * KiB); > >>>>       sd->ext_csd[EXT_CSD_PARTITION_SUPPORT] = 0b111; > >>>>   } else { > >>>>       sd->ext_csd[EXT_CSD_REV] = 3; > >>>>   } > >>> > >>> I need to check if revision 5 still had RPMB as optional (current ones > >>> definitely require it), but I don't think rolling back to revision 3 > >>> would be good idea. If start to add more features from newer revisions, > >>> that may cause even more weird results from the user perspective. I'm > >>> not saying we are fully compliant in one or the other version, rather > >>> that we need to work towards becoming so. Have to support multiple > >>> versions along that will not make it easier. > >> > >> Daniel, do you have a rough idea how many of our build config do > >> not support QCRYPTO_HASH_ALGO_SHA256? > >> (looking about making the SD device unconditional to it). > > > > That's always available, since we can get it from 'glib' even when no > > crypto libs are linked. > > > > Perfect, makes things simpler. > > So what is best practice, assert() availability or silently assume that > it is there? Best practice is always to propagate errors, but if your call chain can't do that, then in this case you can assert or use &error_abort since this should never trigger. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|