Re: [PATCH v3 05/26] include/hw/hyperv: Add MSHV ABI header definitions

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Aug 07, 2025 at 04:39:30PM +0200, Magnus Kulke wrote:
> Introduce headers for the Microsoft Hypervisor (MSHV) userspace ABI,
> including IOCTLs and structures used to interface with the hypervisor.
> 
> These definitions are based on the upstream Linux MSHV interface and
> will be used by the MSHV accelerator backend in later patches.
> 
> Signed-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> ---
>  include/hw/hyperv/hvgdk.h       |  19 +
>  include/hw/hyperv/hvgdk_mini.h  | 864 ++++++++++++++++++++++++++++++++
>  include/hw/hyperv/hvhdk.h       | 164 ++++++
>  include/hw/hyperv/hvhdk_mini.h  | 105 ++++
>  scripts/update-linux-headers.sh |   2 +-
>  5 files changed, 1153 insertions(+), 1 deletion(-)
>  create mode 100644 include/hw/hyperv/hvgdk.h
>  create mode 100644 include/hw/hyperv/hvgdk_mini.h
>  create mode 100644 include/hw/hyperv/hvhdk.h
>  create mode 100644 include/hw/hyperv/hvhdk_mini.h
> 
> diff --git a/include/hw/hyperv/hvgdk.h b/include/hw/hyperv/hvgdk.h
> new file mode 100644
> index 0000000000..d37c2b188d
> --- /dev/null
> +++ b/include/hw/hyperv/hvgdk.h
> @@ -0,0 +1,19 @@

> +#ifndef _HVGDK_H
> +#define _HVGDK_H

The choice of naming scheme for these #ifndef is a bit inconsistent
through this patch, and nit-picking the leading _ is reserved IIRC.


> diff --git a/include/hw/hyperv/hvgdk_mini.h b/include/hw/hyperv/hvgdk_mini.h
> new file mode 100644
> index 0000000000..83f44fd5fa
> --- /dev/null
> +++ b/include/hw/hyperv/hvgdk_mini.h


> +#ifndef HW_HYPERV_LINUX_MSHV_H
> +#define HW_HYPERV_LINUX_MSHV_H

> diff --git a/include/hw/hyperv/hvhdk.h b/include/hw/hyperv/hvhdk.h
> new file mode 100644
> index 0000000000..d22cc49742
> --- /dev/null
> +++ b/include/hw/hyperv/hvhdk.h

> +#ifndef HW_HYPERV_HVHDK_H
> +#define HW_HYPERV_HVHDK_H

> diff --git a/include/hw/hyperv/hvhdk_mini.h b/include/hw/hyperv/hvhdk_mini.h
> new file mode 100644
> index 0000000000..cffd16e0de
> --- /dev/null
> +++ b/include/hw/hyperv/hvhdk_mini.h

> +#ifndef _HVHDK_MINI_H
> +#define _HVHDK_MINI_H

Can we just make all these headers match the relative path under
'include/' as you did for the hvhdk.h file

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|