Re: [PATCH] net: thunderx: Remove redundant ternary operators

[Subbaraya Sundeep <sbhatta@marvell.com>]

On 2025-08-27 at 10:16:07, Liao Yuanhong (liaoyuanhong@vivo.com) wrote:
> For ternary operators in the form of "a ? true : false", if 'a' itself
> returns a boolean result, the ternary operator can be omitted. Remove
> redundant ternary operators to clean up the code.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Subbaraya Sundeep <sbhatta@marell.com>

Looks good to me but a minor comment - include net-next in the subject
Thanks,
Sundeep

> ---
>  drivers/net/ethernet/cavium/thunder/nic_main.c    | 2 +-
>  drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c
> index 0ec65ec634df..b7cf4ba89b7c 100644
> --- a/drivers/net/ethernet/cavium/thunder/nic_main.c
> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
> @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf)
>  		if (mac)
>  			ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac);
>  	}
> -	mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false;
> +	mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en;
>  	mbx.nic_cfg.node_id = nic->node;
>  
>  	mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en;
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 21495b5dce25..10d501ee7b32 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -959,7 +959,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac)
>  		goto next_poll;
>  	}
>  
> -	lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false;
> +	lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0;
>  	an_result = bgx_reg_read(lmac->bgx, lmac->lmacid,
>  				 BGX_GMP_PCS_ANX_AN_RESULTS);
>  
> -- 
> 2.34.1
>