Re: [PATCH v3 net] net: phy: fixed_phy: fix missing calls to gpiod_put in fixed_mdio_bus_exit

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Wed, Aug 27, 2025 at 02:14:54PM -0700, Florian Fainelli wrote:
> On 8/27/25 14:09, Russell King (Oracle) wrote:
> > On Wed, Aug 27, 2025 at 11:02:55PM +0200, Heiner Kallweit wrote:
> > > Cleanup in fixed_mdio_bus_exit() misses to call gpiod_put().
> > > Easiest fix is to call fixed_phy_del() for each possible phy address.
> > > This may consume a few cpu cycles more, but is much easier to read.
> > > 
> > > Fixes: a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
> > 
> > Here's a question that should be considered as well. Do we still need
> > to keep the link-gpios for fixed-phy?
> > 
> > $ grep -r link-gpios arch/*/boot/dts/
> > arch/arm/boot/dts/nxp/vf/vf610-zii-dev-rev-b.dts:                              link-gpios = <&gpio6 2
> > arch/arm/boot/dts/nxp/vf/vf610-zii-dev-rev-b.dts:                              link-gpios = <&gpio6 3
> > 
> > These are used with the mv88e6xxx DSA switch, and DSA being fully
> > converted to phylink, means that fixed-phy isn't used for these
> > link-gpios properties, and hasn't been for some time.
> > 
> > So, is this now redundant code that can be removed, or should we
> > consider updating it for another kernel cycle but print a deprecation
> > notice should someone use it (e.g. openwrt.)
> > 
> > Should we also describe the SFF modules on Zii rev B properly?
> > 
> 
> Do we need to maintain the ZII Device Tree sources given that there has not
> been any work done on those, and it's unclear if they are still even as
> useful as they once were?

Last time I booted mine was in April, because it's the only way I can
test a greater range of Marvell DSA switches. So yes, it gets used
for testing here.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!