From: Yao Zi <ziyao@disroot.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev, Mingcong Bai <jeffbai@aosc.io>,
Kexy Biscuit <kexybiscuit@aosc.io>
Subject: Re: [PATCH 1/3] dt-bindings: reset: Document reset controller of Loongson 2K0300 SoC
Date: Sat, 16 Aug 2025 10:24:45 +0000 [thread overview]
Message-ID: <aKBcbUbx-hgNBOY_@pie> (raw)
In-Reply-To: <d5134909-58a4-48c2-a227-2fb3ce200c2f@kernel.org>
On Sat, Aug 16, 2025 at 11:48:46AM +0200, Krzysztof Kozlowski wrote:
> On 16/08/2025 05:33, Yao Zi wrote:
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + rst: reset-controller@1600011c {
>
> Drop unused label
>
>
> > + compatible = "loongson,ls2k0300-reset";
> > + reg = <0x1600011c 0x8>;
> > + #reset-cells = <1>;
> > + };
> > diff --git a/include/dt-bindings/reset/loongson,ls2k0300-reset.h b/include/dt-bindings/reset/loongson,ls2k0300-reset.h
> > new file mode 100644
> > index 000000000000..d425411e6d19
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/loongson,ls2k0300-reset.h
> > @@ -0,0 +1,70 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>
> Why not using same license as the binding?
I was referring to another binding's header when writing this, and yes
it's better to keep them the same.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Will fix these issues and carry the tag in v2, thanks.
> Best regards,
> Krzysztof
Best regards,
Yao Zi
next prev parent reply other threads:[~2025-08-16 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 3:33 [PATCH 0/3] Support reset controller of Loongson 2K0300 SoC Yao Zi
2025-08-16 3:33 ` [PATCH 1/3] dt-bindings: reset: Document " Yao Zi
2025-08-16 9:48 ` Krzysztof Kozlowski
2025-08-16 10:24 ` Yao Zi [this message]
2025-08-16 3:33 ` [PATCH 2/3] reset: simple: Support " Yao Zi
2025-08-16 3:33 ` [PATCH 3/3] LoongArch: dts: Add reset controller for Loongson 2K0300 Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKBcbUbx-hgNBOY_@pie \
--to=ziyao@disroot.org \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffbai@aosc.io \
--cc=kernel@xen0n.name \
--cc=kexybiscuit@aosc.io \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.