From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-244102.protonmail.ch (mail-244102.protonmail.ch [109.224.244.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49CF9126F0A for ; Sun, 17 Aug 2025 02:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.102 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755399340; cv=none; b=oEUsyxyzEbhBcH0AuoRGqL1ckgfm6ucja0U3v231OauyioO2xbRLkTr3ISBPdv7fhz2n7+rq71K0BajAGvKWlDczG2+WPtu13fhPW+TLUZrCdsDs1c3hBVAqdC4lIqBKvCMQ0Crw+Hu37hd/rbxBfaWOchS9Vjwtsy7Nm3ds9fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755399340; c=relaxed/simple; bh=xiHb5R2Xz2iisIz0D4Ww8xTzFkbohh3hOxPIBl+HOfo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C7pqbaXXJs+7T/hTq3QkryFABj7ynBo2hX2DfEcZFWX/U46ZUkBA2SpPwJzv9Lc6E4oaORopKoDZlYuT0/c281anxba43yg0stulg2swE4ggFmWQpriaHWmkhiUjZSpABszonDssYFS9EQUMqD/Hyzr0iHPHQmbKjc4roYhBjnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weathered-steel.dev; spf=pass smtp.mailfrom=weathered-steel.dev; dkim=pass (2048-bit key) header.d=weathered-steel.dev header.i=@weathered-steel.dev header.b=BA4K8ktN; arc=none smtp.client-ip=109.224.244.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weathered-steel.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weathered-steel.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=weathered-steel.dev header.i=@weathered-steel.dev header.b="BA4K8ktN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weathered-steel.dev; s=protonmail3; t=1755398901; x=1755658101; bh=4f14UHlASZVUziWFh99eMbEfCZAlv2WbhRYGxjgiuL8=; h=Date:From:To:Cc:Subject:Message-ID:References:In-Reply-To:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=BA4K8ktN9i5BjeG7AC459t4GXzCSXO4vC75Horq/n5W5tPWHGp82zyk69DWbh5uPH jip6JjTvzvH6oB/PmUSFJrN6vtjixZuAA+jVE5QeLv+G2raH7Y+H6V3aQvs11Pt/3e fAEjRnR5VNRTJ0W6/XwmLLRpT+HoaQzlomAzaQ0rMuy783vo4C4iPY9JNHplTXmFCg 53MSuiubawv5FDAHAyLayYz7H+Xz478WcN3iMUrZxljBe9tQVy5QViOfIb7z7mkFEq TOFBqeGfpJB9wYoNZBlHwGL5PqbYMjO6nWkXiEAhubATe666MKpbbcGz8WSfMHePeg MZTaZuAc1uu4A== X-Pm-Submission-Id: 4c4Kz75Lzpz1DDL2 Date: Sun, 17 Aug 2025 02:48:17 +0000 From: Elle Rhumsaa To: Shankari Anand Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: drm: update ARef and AlwaysRefCounted imports from sync::aref Message-ID: References: <20250815161706.1324860-1-shankari.ak0208@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250815161706.1324860-1-shankari.ak0208@gmail.com> On Fri, Aug 15, 2025 at 09:47:06PM +0530, Shankari Anand wrote: > Update call sites in drm to import `ARef` and > `AlwaysRefCounted` from `sync::aref` instead of `types`. > > This aligns with the ongoing effort to move `ARef` and > `AlwaysRefCounted` to sync. > > Suggested-by: Benno Lossin > Link: https://github.com/Rust-for-Linux/linux/issues/1173 > Signed-off-by: Shankari Anand > --- > It part of a subsystem-wise split series, as suggested in: > https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u > This split series is intended to ease review and subsystem-level maintenance. > > The original moving patch is here: (commit 07dad44aa9a93) > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440 > > Gradually the re-export from types.rs will be eliminated in the > future cycle. > --- > rust/kernel/drm/device.rs | 3 ++- > rust/kernel/drm/driver.rs | 2 +- > rust/kernel/drm/gem/mod.rs | 3 ++- > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs > index 3bb7c83966cf..4a62f9fd88b7 100644 > --- a/rust/kernel/drm/device.rs > +++ b/rust/kernel/drm/device.rs > @@ -10,7 +10,8 @@ > error::from_err_ptr, > error::Result, > prelude::*, > - types::{ARef, AlwaysRefCounted, Opaque}, > + sync::aref::{ARef, AlwaysRefCounted}, > + types::Opaque, > }; > use core::{mem, ops::Deref, ptr, ptr::NonNull}; > > diff --git a/rust/kernel/drm/driver.rs b/rust/kernel/drm/driver.rs > index fe7e8d06961a..8fefae41bcc6 100644 > --- a/rust/kernel/drm/driver.rs > +++ b/rust/kernel/drm/driver.rs > @@ -8,7 +8,7 @@ > bindings, device, devres, drm, > error::{to_result, Result}, > prelude::*, > - types::ARef, > + sync::aref::ARef, > }; > use macros::vtable; > > diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs > index b71821cfb5ea..a822aedee949 100644 > --- a/rust/kernel/drm/gem/mod.rs > +++ b/rust/kernel/drm/gem/mod.rs > @@ -10,7 +10,8 @@ > drm::driver::{AllocImpl, AllocOps}, > error::{to_result, Result}, > prelude::*, > - types::{ARef, AlwaysRefCounted, Opaque}, > + sync::aref::{ARef, AlwaysRefCounted}, > + types::Opaque, > }; > use core::{mem, ops::Deref, ptr::NonNull}; > > base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585 > -- > 2.34.1 Reviewed-by: Elle Rhumsaa