From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, Yuezhang.Mo@sony.com,
viro@zeniv.linux.org.uk, sj1557.seo@samsung.com,
linkinjeon@kernel.org, jack@suse.cz, brauner@kernel.org,
chizhiling@kylinos.cn
Subject: Re: + mpage-convert-do_mpage_readpage-to-return-int-type.patch added to mm-new branch
Date: Mon, 18 Aug 2025 04:07:52 +0100 [thread overview]
Message-ID: <aKKZCBHCNQYxWKXX@casper.infradead.org> (raw)
In-Reply-To: <20250818024604.7A133C4CEEB@smtp.kernel.org>
On Sun, Aug 17, 2025 at 07:46:03PM -0700, Andrew Morton wrote:
> From: Chi Zhiling <chizhiling@kylinos.cn>
> Subject: mpage: convert do_mpage_readpage() to return int type
> Date: Tue, 12 Aug 2025 15:22:25 +0800
>
> The return value of do_mpage_readpage() is arg->bio, which is already set
> in the arg structure. Returning it again is redundant.
>
> This patch changes the return type to int and always returns 0 since the
> caller does not care about the return value.
This makes no sense. If the caller doesn't care, then it should return
void.
next prev parent reply other threads:[~2025-08-18 3:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 2:46 + mpage-convert-do_mpage_readpage-to-return-int-type.patch added to mm-new branch Andrew Morton
2025-08-18 3:07 ` Matthew Wilcox [this message]
2025-08-18 10:08 ` Chi Zhiling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKKZCBHCNQYxWKXX@casper.infradead.org \
--to=willy@infradead.org \
--cc=Yuezhang.Mo@sony.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=chizhiling@kylinos.cn \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.