From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D76284891; Tue, 19 Aug 2025 07:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755589737; cv=none; b=ZNZ1VgcVEEvHWzc+9d1wtzCs+eLCRpjG+S9hXHw/M8nrleJ7X+u+N/d5NXOMXsKOh0KZ5QYIzPBiNj0zoCVaTmF7ibE9VfDXGyrN+SI/Rd7CO/o4nzr0v9RNVXHJOtlXcHul7DEDyhMg3eYHo2Cy1Pg2yfmHF8ob6BWw9MPiSIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755589737; c=relaxed/simple; bh=Qp0PoTzwfuUghzu0np/WZu53zNwZLmmTS9kXb8pX9b4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nJDpdIVcAh3UGRSXiXpaG5d9Z7Y0vTV366jj8tAy+B3j/0kNFnRa4Kd4Cq10CYD+xGyJPh41MtjwqI9C45wyz2ewU2W7BFoE6LA5q9SLTKYA5Ig+uteIaD36y9qnL9LHuyRHO+TVuel54Dv9u0MCCNSeDt6Y4v38ICkezsbAinc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gj9vDIEC; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gj9vDIEC" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-b47174beb13so3592675a12.2; Tue, 19 Aug 2025 00:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755589735; x=1756194535; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+ht79aZIMlN7H9jxDjI1MTRwr0PcN1XBiR81e8sSRJw=; b=gj9vDIEC8ZZTz4dI8DxCDQv6k3hLkpzG6ug5Qlhl+13sYQFxPBeI5H+PZxdGiRV0CH sRQtqGCfb9Tv70w25ZVYpN/6xmuMjodLNoGCRAVMUycizi5v2nmpLt7LBMdev3PguqDa SL80ng9yBM4oWKwRsZeE1OuYjq7W1yET2ed9WGiw/YuPDfCeHIFqM7zGDddTLGsHiMFE Hzk1+uGt7wKYXeWTjFeZ4vXZjmZeHqcrM9peQ0hA6G89ct27b6c7S5NTf6raEiZnVl/L WW1JyM/iRbf/8P3aaciF8//ccNiVdMn/uoKr720yggt+fjP2qMP33D78NRoPQEkHzLUM /sZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755589735; x=1756194535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+ht79aZIMlN7H9jxDjI1MTRwr0PcN1XBiR81e8sSRJw=; b=XL8wA/EAh7bSlUE3dOf7REOIxx/TkEHdzPzl6TfIYicTWJvv1zKZTSCqbIQtTvsQc+ yJVKLhX6Ysy1CIo0k31i82QBrDkbDhRksa60FZTzkGAUJ6xCoNv5/prxW+aUqoRfwjZv z1pd5LZ/FubHjsKMrH4JLztvOABvF12L1pr25tVV3rni8usZV/LIwxPEVkqxluVPB63H c4AWVhy3ePh4aaACuaPL2MhPODua5/NJ75ImGfKik0iYkiT5Ue1ikLFP3saWxYDYNJTv QJUD21X8XDYcxeVBkkYqWrsD3NIwuQ1KYywLXs0BFaFHiVc+oahr83MH1Vi3mR7VIKuW W9SQ== X-Forwarded-Encrypted: i=1; AJvYcCUaFHLfqwGaBKUw8y+UUm3iWk+75qH1veXViRBFL2M1bjazoGrMUQWTHqvxS6P7OWnuknqGftbdI/ko@vger.kernel.org, AJvYcCX2SAKSpIUkHwtgaJo/tFMhnQipZazj1UwRb61USnOMq2YTolpEwrioedlghmfS3tdtFniV6NqkV/L8ZFho@vger.kernel.org X-Gm-Message-State: AOJu0YxjfZRo4x1MTjM4k5eXUIYyVTGfFIKWcjEpYkQt8ogGbQBAGolu gG0Z0A5mM2KE4pQwXcz0xp2sLF1jTd5/AziZqpas1ztY7nS2zUlBnZaEgQbndB+a X-Gm-Gg: ASbGncuMtao+vX4RHrmow+lC0HY74ptcHh4vtovC0E7tfFCCMHW/H6XY4OHtdddzhtR E41mBYcT1EOLR868qXs72nv8A3hMxAWVtNaicJ9/VmzKAYoRbyUkiwyBJshImkI7bf+3Za8Bw+e V2qDl8VcaT9acTwaJEqNFFzuRwlN93axAzZdw6tXqomLEkjITflur9gF92uqGqnlpE4Bl64x/lD QI3EyTqjf4I3hgldbEcomNN+BLKRN1JibYFtI3ZsZHnqiXuiD/AtZBKQOYRI7gx+4Cwo8FmERYU fDRLhKAtesEaG0NjBRS6lqzntisGgzpAOrevNe+SSFdIrZNLH0e2n/rDZgt5SH7VFPJFyLkUgk8 xcyuu+XdoFaX2/5k= X-Google-Smtp-Source: AGHT+IFyS1pRC/nilFKVPJJNIWYZ8E/oqWs0FiyBi5MrOvkqeJATfICeqlfkAYPlPjxjgr2XEtay5g== X-Received: by 2002:a05:6a20:3d89:b0:23d:e568:e5ad with SMTP id adf61e73a8af0-2430d4753c4mr2069420637.28.1755589735214; Tue, 19 Aug 2025 00:48:55 -0700 (PDT) Received: from anyang ([106.250.177.234]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d122ad7sm1684649b3a.36.2025.08.19.00.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 00:48:54 -0700 (PDT) Date: Tue, 19 Aug 2025 16:48:50 +0900 From: Dongjin Kim To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Change ethernet TXD timing delay value Message-ID: References: <20250819045018.2094282-1-tobetter@gmail.com> <380246b7-7e7a-4843-b82b-2e8d74e01ad5@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <380246b7-7e7a-4843-b82b-2e8d74e01ad5@linaro.org> On Tue, Aug 19, 2025 at 08:42:55AM +0200, Krzysztof Kozlowski wrote: > On 19/08/2025 06:50, Dongjin Kim wrote: > > Very poor network performance is observed on the ODROID-M1 Board > > (REV 1.0 20220613) when running iperf3 (under 200Mbits/sec), and > > this problem can be resolved after changing the value of TXD > > timing to 0x35 from 0x4f. > > > > Signed-off-by: Dongjin Kim > > Change-Id: Idecd246e3fe93447b6e3e9b165d077d2050bbd75 > > > Please run scripts/checkpatch.pl on the patches and fix reported > warnings. After that, run also 'scripts/checkpatch.pl --strict' on the > patches and (probably) fix more warnings. Some warnings can be ignored, > especially from --strict run, but the code here looks like it needs a > fix. Feel free to get in touch if the warning is not clear. Thanks. I realized that I sent unmodified file that includes "Change-Id:". > > You CC-ed an address, which suggests you do not work on mainline kernel > or you do not use get_maintainers.pl/b4/patman. Please rebase and always > work on mainline or start using mentioned tools, so correct addresses > will be used. I've rebased to the master branch, so let me send the patch again. > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36609CA0EF5 for ; Tue, 19 Aug 2025 08:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yELHTa0aEJ2M5ND7S5ruTm9ePX/f2Yd06GxmnJ7x3Oo=; b=vrgYVUlnjsCixA N79+7KBSNUs5G/Isrq14L9DnuSiiURUCElC5TMqaKip6eDBrc73nLwpc/7X7qx1ACBJaN0nFbiMwG 72rFZsXNn0fLa3fm5zdu5/m9sRjIjuzTjKysAi2GWCmAgFODGLHWnR9qmDCAyj2d5bl4wMzUizr3f dVDYbRYg0uYSJKQy81qz5lsKL4GYIMGdQgGY2Sv19pAHq025CD18Omn9nuRpabvmEkBV3Fz3+JpRg 72qTTE2X9FaWRAepk1kif1zREVIr1/pxUkcqKIZNRf3FhfvGTm7wdKTO+u8rASL09E+Lao1J/tRUS II4xlJ80qiCAWBB+AE4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uoHdo-00000009nMX-11DA; Tue, 19 Aug 2025 08:24:24 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uoH5U-00000009is1-1YYq; Tue, 19 Aug 2025 07:48:57 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-76e2e60433eso3752144b3a.0; Tue, 19 Aug 2025 00:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755589735; x=1756194535; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+ht79aZIMlN7H9jxDjI1MTRwr0PcN1XBiR81e8sSRJw=; b=jqG8tPyIHbxHTUn4322CtCZdH/NhlRq88DzR1fRPLB2XKHKmbtOuwOujql/0DPEWSL ipeXKnSPpaxWTUHdeZPvGRcoQ4HrHavcCWyVo4AN2zIdSCPMSMnZBb8OQuIOGkMXuuAq NepWPeFDragi3aF020PEh1UWcA/wSq7OfI70W5stXs82Z5kRb7HRjYFm5W9QyPk/UT9W hU9aboqdeVqL1MskXD87TUjKE6W07O65rlZhjQmDXy5HhcGB2WW0oJKH0uwvOOxKtBra XA4nHsiizt6VHANSYewm8qX5PjjHv8kPA/aoVpPwPfNex3BC6/ClSjIQ0nI+IbnF082J wu9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755589735; x=1756194535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+ht79aZIMlN7H9jxDjI1MTRwr0PcN1XBiR81e8sSRJw=; b=tc9OFJebvwp/jvK3Dy4yfoTYrOOJ1WXD4ZHg6j57pu08tYwohq24t7UucJWiIaz3YI TxieIh7teOlHyQjV7s9fA0gAqsAOV8IMrpicGNEXsso/tXtm3DCYqJRscPNma81uXIHn 7QAD2zFVz5qA+GgbkG3menpA0pa1eZuGOo48S7A75kO6EmLJ8kNGzgR8UF3gyJWfLFgx 9PZTD8BuD1JNzNA2cPQlAAlNPMAK8j1RdsszgTCrK21sr92Rf1esbA1/SKCDnKpG2qYr w48aYb4UYKZKlJYv3Ee+CbnEUl8krITnc8ZuN0ABojTSZSP2KqKKsVmZrYzqfLdJXsnQ SL6Q== X-Forwarded-Encrypted: i=1; AJvYcCUMdCGc8a7pjBaLy4n49VyKi+cBMsOpiLVlzyH/H59HQZz0AkyAVdzTiZUU5Yh3+4sYBdYO428WzkmG0pxlcZVP@lists.infradead.org, AJvYcCX7/OJEaAWDNDrUv3CqFOPkrtFoEKxz69lq45R9MXKfh1zjMhmK+ZKtcMyMi09q2+iMwNrz4bJ6jwgPGOCOzgo=@lists.infradead.org X-Gm-Message-State: AOJu0YyI9Ux32yTsLdLeAOWfVB6uWTxp/OgFdFeKJFZxcNqRYbwZfsPW mqhOVoZuSNYV7DDN8CpablFkhgg2rI7XEINGh/hizE/AwYrOJewSKF3E X-Gm-Gg: ASbGncswCzJzI1B0HcGVYl7dVoLigErC4iaQJiOIJkeEPIOq7gzHDOkz5F/m0Xk38lY lb/3jtkkLgUDCKnYJZwuSUNR2/hp57cU0AycH5VR9BUK4ZegFlxHpIkeIAl1gY7WKzF4l2n0XbY TFZWSSZL7MJzxMTS8UJPyHJJ0fuwda6FcnLClMfhQX2/qnG2f1RXXWzyIKTMjjtVUc2knaUDKTZ jgFof9ZNIJPmlbSxKc0S9eJ6KKNkubRZhAneME/9idJDDBfAVLt8KmZ+b0eFuHfYN9YLZNL6T6L lsHKEfZqMwAZzPaYRnz7Z+AbXcarzwBN0I/T+HrQJP21mfQYFxVX97cstxUuTprMZWRQ+3GODHG x2cWpcIEJqCT80s4= X-Google-Smtp-Source: AGHT+IFyS1pRC/nilFKVPJJNIWYZ8E/oqWs0FiyBi5MrOvkqeJATfICeqlfkAYPlPjxjgr2XEtay5g== X-Received: by 2002:a05:6a20:3d89:b0:23d:e568:e5ad with SMTP id adf61e73a8af0-2430d4753c4mr2069420637.28.1755589735214; Tue, 19 Aug 2025 00:48:55 -0700 (PDT) Received: from anyang ([106.250.177.234]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d122ad7sm1684649b3a.36.2025.08.19.00.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 00:48:54 -0700 (PDT) Date: Tue, 19 Aug 2025 16:48:50 +0900 From: Dongjin Kim To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Change ethernet TXD timing delay value Message-ID: References: <20250819045018.2094282-1-tobetter@gmail.com> <380246b7-7e7a-4843-b82b-2e8d74e01ad5@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <380246b7-7e7a-4843-b82b-2e8d74e01ad5@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250819_004856_428537_45F29F49 X-CRM114-Status: GOOD ( 21.65 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Aug 19, 2025 at 08:42:55AM +0200, Krzysztof Kozlowski wrote: > On 19/08/2025 06:50, Dongjin Kim wrote: > > Very poor network performance is observed on the ODROID-M1 Board > > (REV 1.0 20220613) when running iperf3 (under 200Mbits/sec), and > > this problem can be resolved after changing the value of TXD > > timing to 0x35 from 0x4f. > > > > Signed-off-by: Dongjin Kim > > Change-Id: Idecd246e3fe93447b6e3e9b165d077d2050bbd75 > > > Please run scripts/checkpatch.pl on the patches and fix reported > warnings. After that, run also 'scripts/checkpatch.pl --strict' on the > patches and (probably) fix more warnings. Some warnings can be ignored, > especially from --strict run, but the code here looks like it needs a > fix. Feel free to get in touch if the warning is not clear. Thanks. I realized that I sent unmodified file that includes "Change-Id:". > > You CC-ed an address, which suggests you do not work on mainline kernel > or you do not use get_maintainers.pl/b4/patman. Please rebase and always > work on mainline or start using mentioned tools, so correct addresses > will be used. I've rebased to the master branch, so let me send the patch again. > > Best regards, > Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip