Re: [PATCH 3/4] tests/functional: Mark main in QemuBaseTest class as a static method

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Aug 19, 2025 at 02:39:15PM +0000, Gustavo Romero wrote:
> The main() method in the QemuBaseTest class has no parameters but is
> defined as a regular method. Currently, this does not cause any issues
> because in the functional tests main() is always called directly from
> QemuBaseTest (never from instances), but the way this method is defined
> makes its signature wrong, implying a 'self'. Hence, it's best practice
> to define such a method as a static method, so decorate it with
> @staticmethod.
> 
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>  tests/functional/qemu_test/testcase.py | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|