On Mon, Aug 18, 2025 at 12:35:46PM +0200, Uwe Kleine-König wrote: > Removing the complete __fixups__ and __local_fixups__ tree might delete > data that should better be retained. See the added test for a situation > that was broken before. > > Note that without removing /__fixups__ and /__local_fixups__ in > generate_fixups_tree() and generate_local_fixups_tree() respectively > calling build_and_name_child_node() isn't safe as the nodes might > already exist and then a duplicate would be added. So build_root_node() > has to be used which copes correctly here. > > Fixes: 915daadbb62d ("Start with empty __local_fixups__ and __fixups__ nodes") > Closes: https://github.com/dgibson/dtc/issues/170 > Signed-off-by: Uwe Kleine-König Merged. thanks. Note that I generally prefer negative values for error codes (-1 instead of 1). I altered that on merge. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson