From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Adrian Barnaś" <abarnas@google.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: Whitespaces style cleanup in gdc.c
Date: Wed, 20 Aug 2025 16:07:44 +0300 [thread overview]
Message-ID: <aKXIoFpHUjSdCbHY@smile.fi.intel.com> (raw)
In-Reply-To: <20250820124519.2287171-1-abarnas@google.com>
On Wed, Aug 20, 2025 at 12:45:19PM +0000, Adrian Barnaś wrote:
> NFC: This patch cleans up coding style whitespace issues
> in drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
>
> Fixes include:
> - removal of unnecessary line breaks
> - correcting spacing around operators
> - correcting spaces between types and names
...
> -static inline void gdc_reg_store(
> - const gdc_ID_t ID,
> - const unsigned int reg,
> - const hrt_data value);
> +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,
> + const hrt_data value);
Can you rather refactor code to get rid of the forward declaration?
...
> +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,
This still is wrong, shouldn't be any tabs here.
> + const hrt_data value)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-20 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 12:45 [PATCH] staging: media: atomisp: Whitespaces style cleanup in gdc.c Adrian Barnaś
2025-08-20 13:04 ` Dan Carpenter
2025-08-20 13:05 ` Greg Kroah-Hartman
2025-08-20 13:07 ` Andy Shevchenko [this message]
[not found] ` <CAATBrPGqkuLrVhKi8aj-tugZNVMD3kqv5_v3WB=kJvt4FVtFzw@mail.gmail.com>
2025-08-21 6:37 ` Fwd: " Adrian Barnaś
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXIoFpHUjSdCbHY@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abarnas@google.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.