From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] mnl: silence compiler warning
Date: Wed, 20 Aug 2025 15:22:20 +0200 [thread overview]
Message-ID: <aKXMDPl1q7Z5bei8@calendula> (raw)
In-Reply-To: <20250820124447.31695-1-fw@strlen.de>
On Wed, Aug 20, 2025 at 02:44:43PM +0200, Florian Westphal wrote:
> gcc 14.3.0 reports this:
>
> src/mnl.c: In function 'mnl_nft_chain_add':
> src/mnl.c:916:25: warning: 'nest' may be used uninitialized [-Wmaybe-uninitialized]
> 916 | mnl_attr_nest_end(nlh, nest);
>
> I guess its because compiler can't know that the conditions cannot change
> in-between and assumes nest_end() can be called without nest_start().
>
> Fixes: 01277922fede ("src: ensure chain policy evaluation when specified")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Thanks for this fix.
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2025-08-20 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 12:44 [PATCH nft] mnl: silence compiler warning Florian Westphal
2025-08-20 13:22 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXMDPl1q7Z5bei8@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.